Bug 148243 - Web Inspector: Add flex alignment section to Visual sidebar
Summary: Web Inspector: Add flex alignment section to Visual sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 147563
  Show dependency tree / graph
 
Reported: 2015-08-20 14:04 PDT by Devin Rousso
Modified: 2015-08-20 18:42 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.99 KB, patch)
2015-08-20 16:30 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2015-08-20 14:04:51 PDT 
Currently, the layout properties for flex box have visual editors, but the alignment (align, justify, etc.) properties do not.
Comment 1 Radar WebKit Bug Importer 2015-08-20 14:05:54 PDT 
<rdar://problem/22367976>
Comment 2 Devin Rousso 2015-08-20 16:30:01 PDT 
Created attachment 259517 [details]
Patch
Comment 3 Timothy Hatcher 2015-08-20 17:12:32 PDT 
Comment on attachment 259517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review

> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590
> +            advanced: advancedAlignmentKeywords.concat(["Space Evenly"])

Really advanced? I could see this being in the basic list.
Comment 4 Devin Rousso 2015-08-20 17:13:30 PDT 
Comment on attachment 259517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review

>> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590
>> +            advanced: advancedAlignmentKeywords.concat(["Space Evenly"])
> 
> Really advanced? I could see this being in the basic list.

I put it in the advanced list because it is a CSS Grid layout keyword and doesn't work for Flexbox.  Since Grid is much less supported than Flexbox, I don't want the users getting confused.
Comment 5 Timothy Hatcher 2015-08-20 17:14:16 PDT 
Comment on attachment 259517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review

>>> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590
>>> +            advanced: advancedAlignmentKeywords.concat(["Space Evenly"])
>> 
>> Really advanced? I could see this being in the basic list.
> 
> I put it in the advanced list because it is a CSS Grid layout keyword and doesn't work for Flexbox.  Since Grid is much less supported than Flexbox, I don't want the users getting confused.

Makes sense.
Comment 6 WebKit Commit Bot 2015-08-20 18:42:31 PDT 
Comment on attachment 259517 [details]
Patch

Clearing flags on attachment: 259517

Committed r188733: <http://trac.webkit.org/changeset/188733>
Comment 7 WebKit Commit Bot 2015-08-20 18:42:34 PDT 
All reviewed patches have been landed.  Closing bug.