Default value for createNodeIterator() / createTreeWalker()'s whatToShow parameter should be 0xFFFFFFFF not 0 as per the specification: https://dom.spec.whatwg.org/#document Chrome and Firefox conform to the specification. Test suite: http://w3c-test.org/dom/traversal/NodeIterator.html http://w3c-test.org/dom/traversal/TreeWalker.html
Created attachment 259501 [details] Patch
Comment on attachment 259501 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259501&action=review > Source/WebCore/dom/Document.idl:93 > + [ObjCLegacyUnnamedParameters] NodeIterator createNodeIterator(Node root, > + optional unsigned long whatToShow, > + optional NodeFilter? filter, > + optional boolean expandEntityReferences); > + [ObjCLegacyUnnamedParameters] TreeWalker createTreeWalker(Node root, > + optional unsigned long whatToShow, > + optional NodeFilter? filter, > + optional boolean expandEntityReferences); Can we use WebKit-style indentation (indent by 4 spaces)?
Created attachment 259509 [details] Patch
Comment on attachment 259509 [details] Patch Clearing flags on attachment: 259509 Committed r188711: <http://trac.webkit.org/changeset/188711>
All reviewed patches have been landed. Closing bug.