Bug 148228 - A watchdog tests is failing on Windows
Summary: A watchdog tests is failing on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-20 09:42 PDT by Mark Lam
Modified: 2015-08-20 10:41 PDT (History)
2 users (show)

See Also:

Attachments
the fix. (1.79 KB, patch)
2015-08-20 09:50 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-08-20 09:42:59 PDT 
Because of Window's low resolution timer, the failing test's time targets were not met.  By giving the test a little more time, the failure was resolved.
Comment 1 Mark Lam 2015-08-20 09:50:04 PDT 
Created attachment 259475 [details]
the fix.
Comment 2 Brent Fulgham 2015-08-20 09:56:49 PDT 
Comment on attachment 259475 [details]
the fix.

I wonder if we can figure out some kind of threshold to use to support Windows in future tests.

Thank you for figuring this out!

r=me.
Comment 3 WebKit Commit Bot 2015-08-20 10:41:52 PDT 
Comment on attachment 259475 [details]
the fix.

Clearing flags on attachment: 259475

Committed r188689: <http://trac.webkit.org/changeset/188689>
Comment 4 WebKit Commit Bot 2015-08-20 10:41:55 PDT 
All reviewed patches have been landed.  Closing bug.