Bug 148216 - [Cocoa] Clean up Font class
Summary: [Cocoa] Clean up Font class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on: 148278
Blocks:
  Show dependency tree / graph
 
Reported: 2015-08-20 01:04 PDT by Myles C. Maxfield
Modified: 2015-08-21 16:34 PDT (History)
6 users (show)

See Also:

Attachments
Patch (26.80 KB, patch)
2015-08-20 01:15 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (337.52 KB, application/zip)
2015-08-20 01:56 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-mavericks (346.09 KB, application/zip)
2015-08-20 02:08 PDT, Build Bot 		no flags Details
Patch (6.33 KB, patch)
2015-08-20 19:34 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (827.73 KB, application/zip)
2015-08-20 20:16 PDT, Build Bot 		no flags Details
Patch (6.36 KB, patch)
2015-08-20 20:19 PDT, Myles C. Maxfield 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-08-20 01:04:45 PDT 
[Cocoa] Clean up Font class
Comment 1 Myles C. Maxfield 2015-08-20 01:15:32 PDT 
Created attachment 259458 [details]
Patch
Comment 2 Build Bot 2015-08-20 01:56:27 PDT 
Comment on attachment 259458 [details]
Patch

Attachment 259458 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/78426

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2015-08-20 01:56:30 PDT 
Created attachment 259462 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 4 Myles C. Maxfield 2015-08-20 02:01:02 PDT 
Comment on attachment 259458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259458&action=review

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:-111
> -#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90000

There's a big block above that I can delete too.
Comment 5 Build Bot 2015-08-20 02:08:46 PDT 
Comment on attachment 259458 [details]
Patch

Attachment 259458 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/78443

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2015-08-20 02:08:48 PDT 
Created attachment 259463 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 7 Myles C. Maxfield 2015-08-20 19:34:33 PDT 
Created attachment 259566 [details]
Patch
Comment 8 Build Bot 2015-08-20 20:16:13 PDT 
Comment on attachment 259566 [details]
Patch

Attachment 259566 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/83981

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2015-08-20 20:16:16 PDT 
Created attachment 259575 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 10 Myles C. Maxfield 2015-08-20 20:19:38 PDT 
Created attachment 259576 [details]
Patch
Comment 11 Dean Jackson 2015-08-21 13:38:46 PDT 
Comment on attachment 259576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259576&action=review

> Source/WebCore/platform/graphics/Font.cpp:-126
> -        m_spaceGlyph = 0;
> -        m_spaceWidth = 0;
> -        m_zeroGlyph = 0;
> -        m_adjustedSpaceWidth = 0;
>          determinePitch();
> -        m_zeroWidthSpaceGlyph = 0;

I assume it isn't a behaviour change if glyphPageZero isn't null? (you're now initialising all these to 0 elsewhere)
Comment 12 Myles C. Maxfield 2015-08-21 16:32:40 PDT 
Comment on attachment 259576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259576&action=review

>> Source/WebCore/platform/graphics/Font.cpp:-126
>> -        m_zeroWidthSpaceGlyph = 0;
> 
> I assume it isn't a behaviour change if glyphPageZero isn't null? (you're now initialising all these to 0 elsewhere)

They get initialized directly below this. Lines 127 to 138.
Comment 13 Myles C. Maxfield 2015-08-21 16:34:19 PDT 
Committed r188797: <http://trac.webkit.org/changeset/188797>