Bug 148216 – [Cocoa] Clean up Font class

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Cocoa] Clean up Font class

[Myles C. Maxfield]

Created attachment 259458 [details]
Patch

[Build Bot]

Comment on attachment 259458 [details]
Patch

Attachment 259458 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/78426

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 259462 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Myles C. Maxfield]

Comment on attachment 259458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259458&action=review

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:-111
> -#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90000

There's a big block above that I can delete too.

[Build Bot]

Comment on attachment 259458 [details]
Patch

Attachment 259458 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/78443

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 259463 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Myles C. Maxfield]

Created attachment 259566 [details]
Patch

[Build Bot]

Comment on attachment 259566 [details]
Patch

Attachment 259566 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/83981

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 259575 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Myles C. Maxfield]

Created attachment 259576 [details]
Patch

[Dean Jackson]

Comment on attachment 259576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259576&action=review

> Source/WebCore/platform/graphics/Font.cpp:-126
> -        m_spaceGlyph = 0;
> -        m_spaceWidth = 0;
> -        m_zeroGlyph = 0;
> -        m_adjustedSpaceWidth = 0;
>          determinePitch();
> -        m_zeroWidthSpaceGlyph = 0;

I assume it isn't a behaviour change if glyphPageZero isn't null? (you're now initialising all these to 0 elsewhere)

[Myles C. Maxfield]

Comment on attachment 259576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259576&action=review

>> Source/WebCore/platform/graphics/Font.cpp:-126
>> -        m_zeroWidthSpaceGlyph = 0;
> 
> I assume it isn't a behaviour change if glyphPageZero isn't null? (you're now initialising all these to 0 elsewhere)

They get initialized directly below this. Lines 127 to 138.

[Myles C. Maxfield]

Committed r188797: <http://trac.webkit.org/changeset/188797>