Bug 148202 – Add some new emoji with modifiers and new sequence

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Enrica Casucci]

Supporting some new emoji with modifiers.

rdar://problem/21849857

[Enrica Casucci]

Created attachment 259492 [details]
Patch

[Build Bot]

Comment on attachment 259492 [details]
Patch

Attachment 259492 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/80706

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 259499 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 259492 [details]
Patch

Attachment 259492 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/80708

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 259500 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Enrica Casucci]

Created attachment 259941 [details]
Patch2

[Sam Weinig]

Comment on attachment 259941 [details]
Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=259941&action=review

> LayoutTests/ChangeLog:25
> [phone]  Enrica Casucci  <[e-mail]>
> +
> +        Add some new emoji with modifiers and new sequence.
> +        https://bugs.webkit.org/show_bug.cgi?id=148202
> +        rdar://problem/21849857
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Updated test to reflect the changes.
> +
> +        * editing/deleting/delete-emoji-expected.txt:
> +        * editing/deleting/delete-emoji.html:
> +
> [phone]  Enrica Casucci  <[e-mail]>
> +
> +        Add some new emoji with modifiers and new sequence.
> +        https://bugs.webkit.org/show_bug.cgi?id=148202
> +        rdar://problem/21849857
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test updated to test the new emoji and the new sequence.
> +
> +        * editing/deleting/delete-emoji-expected.txt:
> +        * editing/deleting/delete-emoji.html:

Double changelog.

[Enrica Casucci]

Committed revision 188960.

[Csaba Osztrogonác]

(In reply to comment #8)
> Committed revision 188960.

It made zillion tests crash on all bots, see build.webkit.org for details.

[Enrica Casucci]

I don't see any crashlogs unfortunately. I'll take a look at what happens.

[Csaba Osztrogonác]

(In reply to comment #10)
> I don't see any crashlogs unfortunately. I'll take a look at what happens.

Apple's debug buildbots do provide crashlogs:
https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29/r188960%20%2815165%29/results.html
https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/r188960%20%2814058%29/results.html
https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20%28Tests%29/r188960%20%287034%29/results.html
https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20%28Tests%29/r188960%20%286531%29/results.html

[Enrica Casucci]

(In reply to comment #11)
> (In reply to comment #10)
> > I don't see any crashlogs unfortunately. I'll take a look at what happens.
> 
> Apple's debug buildbots do provide crashlogs:
> https://build.webkit.org/results/
> Apple%20Mavericks%20Debug%20WK1%20%28Tests%29/r188960%20%2815165%29/results.
> html
> https://build.webkit.org/results/
> Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/r188960%20%2814058%29/results.
> html
> https://build.webkit.org/results/
> Apple%20Yosemite%20Debug%20WK1%20%28Tests%29/r188960%20%287034%29/results.
> html
> https://build.webkit.org/results/
> Apple%20Yosemite%20Debug%20WK2%20%28Tests%29/r188960%20%286531%29/results.
> html

I found them in our internal bots too. I'm investigating.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 148479

[Enrica Casucci]

Created attachment 260053 [details]
Patch3

[Enrica Casucci]

Committed revision 189024.