Bug 148190 – Web Inspector: Uncaught Exceptions regarding PseudoElements / TemplateContent

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Uncaught Exceptions regarding PseudoElements / TemplateContent.

* STEPS TO REPRODUCE
1. Inspect twitter.com
2. Navigate around twitter.com
3. Reload
  => uncaught exceptions in inspector

* ERRORS
Resources/Protocol/InspectorBackend.js:281:26: CONSOLE ERROR Uncaught exception in inspector page while handling event DOM.pseudoElementRemoved:  TypeError: null is not an object (evaluating 'this._children.length') [e-mail]/Resources/Models/DOMNode.js:559:44
Resources/Protocol/InspectorBackend.js:281:26: CONSOLE ERROR Uncaught exception in inspector page while handling event DOM.childNodeRemoved:  TypeError: node.templateContent is not a function. (In 'node.templateContent()', 'node.templateContent' is undefined) [e-mail]/Resources/Controllers/DOMTreeManager.js:292:33

[Joseph Pecoraro]

Created attachment 259402 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 259402 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=259402&action=review

r=me

> Source/WebInspectorUI/ChangeLog:14
> +        exists, it may be null. So separate the two pathes.

paths*

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:289
> +        for (let i = 0; node.children && i < node.children.length; ++i)

This could be for (let .. of ..), since it doesn't mutate node.children.

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:296
> +        let pseudoElements = node.pseudoElements();

No need for a local.

[Joseph Pecoraro]

Created attachment 259430 [details]
[PATCH] For Landing

[WebKit Commit Bot]

Comment on attachment 259430 [details]
[PATCH] For Landing

Clearing flags on attachment: 259430

Committed r188670: <http://trac.webkit.org/changeset/188670>

[Joseph Pecoraro]

This landed, see above comment.