Bug 148169 - functions that use try/catch will allocate a top level JSLexicalEnvironment even when it is not necessary
Summary: functions that use try/catch will allocate a top level JSLexicalEnvironment e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-19 00:19 PDT by Saam Barati
Modified: 2015-09-15 12:27 PDT (History)
10 users (show)

See Also:


Attachments
patch (6.50 KB, patch)
2015-09-14 18:59 PDT, Saam Barati
no flags Details | Formatted Diff | Diff
patch (6.79 KB, patch)
2015-09-14 19:08 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-08-19 00:19:12 PDT
Even if no "var"s need to go into the environment, byte code will create one.
This is probably an easy parser/bytecodegenerator change to fix.
Comment 1 Saam Barati 2015-09-14 18:59:50 PDT
Created attachment 261160 [details]
patch
Comment 2 Saam Barati 2015-09-14 19:08:34 PDT
Created attachment 261161 [details]
patch
Comment 3 Geoffrey Garen 2015-09-15 11:11:33 PDT
Comment on attachment 261161 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2015-09-15 12:26:59 PDT
Comment on attachment 261161 [details]
patch

Clearing flags on attachment: 261161

Committed r189819: <http://trac.webkit.org/changeset/189819>
Comment 5 WebKit Commit Bot 2015-09-15 12:27:04 PDT
All reviewed patches have been landed.  Closing bug.