Bug 148164 - [Cocoa] Punctuation near Hindi text is garbled when styled with the system font
Summary: [Cocoa] Punctuation near Hindi text is garbled when styled with the system font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-18 21:55 PDT by Myles C. Maxfield
Modified: 2015-08-19 08:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.69 KB, patch)
2015-08-18 22:03 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (5.99 KB, patch)
2015-08-18 22:29 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-08-18 21:55:31 PDT 
[Cocoa] Punctuation near Hindi text is garbled when styled with the system font
Comment 1 Myles C. Maxfield 2015-08-18 22:03:58 PDT 
Created attachment 259354 [details]
Patch
Comment 2 Myles C. Maxfield 2015-08-18 22:04:48 PDT 
<rdar://problem/22335832>
Comment 3 BJ Burg 2015-08-18 22:22:22 PDT 
Comment on attachment 259354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259354&action=review

r=me

If it's not too much a bother, please update changelog to explain why hitting the empty cache affects Japanese language and hindi characters specifically, and not an arbitrary script/language combination.

> Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:96
> +    // FIXME: Unify these two codepaths

Nit: trailing period
Comment 4 Alexey Proskuryakov 2015-08-18 22:29:16 PDT 
Comment on attachment 259354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259354&action=review

> LayoutTests/fast/text/hindi-system-font-punctuation.html:3
> +This test makes sure that punctuation next to Hindi characters are rendered as expected when the system language is set to Japanese.

Is the test effective? There doesn't seem to be anything Japanese about it.
Comment 5 Myles C. Maxfield 2015-08-18 22:29:27 PDT 
Created attachment 259356 [details]
Patch
Comment 6 BJ Burg 2015-08-18 22:35:14 PDT 
Comment on attachment 259356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259356&action=review

> Source/WebCore/ChangeLog:13
> +        Consulting with the cache before it is populated causes it to erreneously say that no fonts are system fonts.

erroneously
Comment 7 BJ Burg 2015-08-18 22:36:57 PDT 
(In reply to comment #4)
> Comment on attachment 259354 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259354&action=review
> 
> > LayoutTests/fast/text/hindi-system-font-punctuation.html:3
> > +This test makes sure that punctuation next to Hindi characters are rendered as expected when the system language is set to Japanese.
> 
> Is the test effective? There doesn't seem to be anything Japanese about it.

Myles, could you add a comment (in the changelog) about this test's dependency on a particular system language? If you have filed a bug for adding that capability to the test harness, please link it.
Comment 8 Myles C. Maxfield 2015-08-18 23:23:56 PDT 
Committed r188634: <http://trac.webkit.org/changeset/188634>
Comment 9 BJ Burg 2015-08-19 08:23:55 PDT 
(In reply to comment #8)
> Committed r188634: <http://trac.webkit.org/changeset/188634>

The changelog is glorious. Thank you.