Bug 148159 - Cleanup outline-style: auto painting.
Summary: Cleanup outline-style: auto painting.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-18 20:00 PDT by zalan
Modified: 2015-08-19 15:09 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.75 KB, patch)
2015-08-18 20:02 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (13.12 KB, patch)
2015-08-18 20:49 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (13.43 KB, patch)
2015-08-19 14:29 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-08-18 20:00:53 PDT
Remove pre-history logic and adjust html.css.
Comment 1 zalan 2015-08-18 20:02:45 PDT
Created attachment 259343 [details]
Patch
Comment 2 zalan 2015-08-18 20:03:10 PDT
EWS testing first.
Comment 3 zalan 2015-08-18 20:49:50 PDT
Created attachment 259344 [details]
Patch
Comment 4 Simon Fraser (smfr) 2015-08-19 12:10:58 PDT
Comment on attachment 259344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259344&action=review

> Source/WebCore/ChangeLog:8
> +        Old platform style required the focus ring to be painted with an offset.

Would be nice if you could be more specific about the history of the code (like to specific trac revisions).

> Source/WebCore/ChangeLog:12
> +        This patch removes both the old logic and the workaround for getting rid of the unwanted offset.

It also short-circuits RenderElement::paintOutline() when painting is disabled. Is that OK?
Comment 5 zalan 2015-08-19 14:29:25 PDT
Created attachment 259406 [details]
Patch
Comment 6 zalan 2015-08-19 14:31:11 PDT
(In reply to comment #4)
> Comment on attachment 259344 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259344&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Old platform style required the focus ring to be painted with an offset.
> 
> Would be nice if you could be more specific about the history of the code
> (like to specific trac revisions).
Done.

> 
> > Source/WebCore/ChangeLog:12
> > +        This patch removes both the old logic and the workaround for getting rid of the unwanted offset.
> 
> It also short-circuits RenderElement::paintOutline() when painting is
> disabled. Is that OK?
Focus ring painting is already short circuited the only behavior change is for non-auto outlines and I supposed they are not meant to be painted when painting is disabled.
Comment 7 WebKit Commit Bot 2015-08-19 15:09:36 PDT
Comment on attachment 259406 [details]
Patch

Clearing flags on attachment: 259406

Committed r188652: <http://trac.webkit.org/changeset/188652>
Comment 8 WebKit Commit Bot 2015-08-19 15:09:40 PDT
All reviewed patches have been landed.  Closing bug.