Bug 148155 – Scroll snapping should trigger when receiving a momentum end wheel event

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Wenson Hsieh]

Scroll snapping should trigger when receiving a wheel event indicating momentum end. This will allow our failing scroll snapping layout tests to pass, since asynchronous momentum wheel events are currently being coalesced. However, in theory, if a user were to flick extremely lightly on the trackpad and generate fewer than 3 wheel momentum events before letting go, scroll snapping would not occur.

[Wenson Hsieh]

<rdar://problem/22336880>

[Wenson Hsieh]

Created attachment 259361 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 259361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259361&action=review

> Source/WebCore/platform/cocoa/ScrollController.mm:571
> +        else {
> +            snapState.clearInitialWheelDeltaWindow();
> +            snapState.m_shouldOverrideWheelEvent = false;
> +        }

It's not obvious to me why this is inside an "else". beginScrollSnapAnimation does set these variables, but not in all code paths.

[Wenson Hsieh]

Comment on attachment 259361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259361&action=review

Thanks for the review!

>> Source/WebCore/platform/cocoa/ScrollController.mm:571
>> +        }
> 
> It's not obvious to me why this is inside an "else". beginScrollSnapAnimation does set these variables, but not in all code paths.

Good point. I should be able to lift the logic to reset the delta window and override state out of the else clause, since we should be doing this anyway even if we don't trigger a glide here.

[Wenson Hsieh]

Committed r188641: <http://trac.webkit.org/changeset/188641>