RESOLVED FIXED 148153
Web Inspector: Visual editor links should unlink when switching styles 
https://bugs.webkit.org/show_bug.cgi?id=148153
Summary Web Inspector: Visual editor links should unlink when switching styles
Devin Rousso
Reported 2015-08-18 16:53:44 PDT
Currently, the editor links stay active until the user disables them, even when switching rules/nodes. This should be changed such that the link deactivates whenever the rule/node changes to prevent unwanted syncing between editors.
Attachments
Patch (8.53 KB, patch)
2015-08-18 16:56 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-18 16:54:29 PDT
<rdar://problem/22335395>
Devin Rousso
Comment 2 2015-08-18 16:56:40 PDT
Created attachment 259322 [details] Patch
Timothy Hatcher
Comment 3 2015-08-18 17:04:21 PDT
Comment on attachment 259322 [details] Patch Maybe it should auto link if the values match?
Devin Rousso
Comment 4 2015-08-18 17:10:58 PDT
(In reply to comment #3) > Maybe it should auto link if the values match? I was tempted to add this, but I feel that that may be assuming too much about what the user intends to do. If they really want to link the editors, they click the link to make that happen.
Timothy Hatcher
Comment 5 2015-08-18 17:12:36 PDT
Alright. Sounds good.
WebKit Commit Bot
Comment 6 2015-08-18 18:42:06 PDT
Comment on attachment 259322 [details] Patch Clearing flags on attachment: 259322 Committed r188621: <http://trac.webkit.org/changeset/188621>
WebKit Commit Bot
Comment 7 2015-08-18 18:42:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.