WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
148152
OSR exit should have a direct reference to its target CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=148152
Summary
OSR exit should have a direct reference to its target CodeBlock
Geoffrey Garen
Reported
2015-08-18 16:42:15 PDT
From InlineCallFrame.h: // FIXME: It's dangerous that OSR exit asks the Executable for a CodeBlock // instead of having a pointer to a CodeBlock. If the GC discards a // CodeBlock that we inline, then we will see a different CodeBlock // at OSR time than we saw at compilation time. This works if compilation // is mostly pure and the two CodeBlocks are equivalent, but that is a // fragile thing to rely on. inline CodeBlock* baselineCodeBlockForInlineCallFrame(InlineCallFrame* inlineCallFrame) { RELEASE_ASSERT(inlineCallFrame); ScriptExecutable* executable = inlineCallFrame->executable.get(); RELEASE_ASSERT(executable->structure()->classInfo() == FunctionExecutable::info()); return static_cast<FunctionExecutable*>(executable)->baselineCodeBlockFor(inlineCallFrame->specializationKind()); }
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug