Bug 148146 - Search input results and clear icons are misaligned when padding is added
Summary: Search input results and clear icons are misaligned when padding is added
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Macintosh Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-18 15:38 PDT by Wenson Hsieh
Modified: 2015-08-18 17:23 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.31 KB, patch)
2015-08-18 16:27 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (5.38 KB, patch)
2015-08-18 16:31 PDT, Wenson Hsieh
zalan: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-mavericks (612.00 KB, application/zip)
2015-08-18 16:48 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (657.69 KB, application/zip)
2015-08-18 17:00 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2015-08-18 15:38:12 PDT
Open an HTML file with <input style="-webkit-appearance: textfield; padding: 10px;" value=test type=search results=5>. Observe that the magnifying glass (for results) and the cancel button are both clipped by the padding.
Comment 1 Wenson Hsieh 2015-08-18 15:38:52 PDT
<rdar://problem/22310951>
Comment 2 Wenson Hsieh 2015-08-18 16:27:09 PDT
Created attachment 259312 [details]
Patch
Comment 3 Wenson Hsieh 2015-08-18 16:31:24 PDT
Created attachment 259314 [details]
Patch
Comment 4 Build Bot 2015-08-18 16:48:55 PDT
Comment on attachment 259314 [details]
Patch

Attachment 259314 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/73346

New failing tests:
platform/mac/fast/forms/search/search-padding-cancel-results-buttons.html
Comment 5 Build Bot 2015-08-18 16:48:58 PDT
Created attachment 259321 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Build Bot 2015-08-18 17:00:51 PDT
Comment on attachment 259314 [details]
Patch

Attachment 259314 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/73402

New failing tests:
platform/mac/fast/forms/search/search-padding-cancel-results-buttons.html
Comment 7 Build Bot 2015-08-18 17:00:54 PDT
Created attachment 259323 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 8 Wenson Hsieh 2015-08-18 17:23:55 PDT
Committed r188611: <http://trac.webkit.org/changeset/188611>