Bug 148142 - Add metadata to Dashboard.Repository for SCM type.
Summary: Add metadata to Dashboard.Repository for SCM type.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2015-08-18 14:26 PDT by Jason Marcell
Modified: 2015-09-14 10:59 PDT (History)
7 users (show)

See Also:

Patch (1.87 KB, patch)
2015-08-18 14:29 PDT, Jason Marcell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Marcell 2015-08-18 14:26:16 PDT
Add metadata to Dashboard.Repository for SCM type.
Comment 1 Jason Marcell 2015-08-18 14:29:59 PDT
Created attachment 259297 [details]
Comment 2 Jason Marcell 2015-08-18 14:33:56 PDT
Comment on attachment 259297 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=259297&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:28
> +    GIT: 1

Should this be GIT in all caps? For that matter, is SVN an appropriate key for Subversion?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:32
> +    SCMTypes: SCMTypes,

I defined SCMTypes outside of Dashboard so that I could refer to it in the Dashboard.Repository section. But I also want to refer to them as Dashboard.SCMTypes.SVN, etc., so I added a key "SCMTypes" here. I don't really like this, but I'm open to other suggestions.
Comment 3 Jason Marcell 2015-08-27 17:13:16 PDT
We went with this instead: https://bugs.webkit.org/attachment.cgi?id=259779
Comment 4 Csaba Osztrogonác 2015-09-14 10:59:48 PDT
Comment on attachment 259297 [details]

Cleared review? from attachment 259297 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).