Bug 148140 - Replace all uses of std::mutex/std::condition_variable with WTF::Lock/WTF::Condition
Summary: Replace all uses of std::mutex/std::condition_variable with WTF::Lock/WTF::Co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 147841 157924
  Show dependency tree / graph
 
Reported: 2015-08-18 14:08 PDT by Filip Pizlo
Modified: 2016-05-19 14:38 PDT (History)
13 users (show)

See Also:

Attachments
work so far (50.52 KB, patch)
2015-08-18 17:46 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
it is written (116.28 KB, patch)
2015-08-18 18:57 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (118.19 KB, patch)
2015-08-18 20:50 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (118.62 KB, patch)
2015-08-18 21:21 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (118.64 KB, patch)
2015-08-18 22:01 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-08-18 14:08:27 PDT 
WTF's locking primitives are way faster and way smaller.  We should use those always.
Comment 1 Filip Pizlo 2015-08-18 17:46:01 PDT 
Created attachment 259335 [details]
work so far
Comment 2 Filip Pizlo 2015-08-18 18:57:00 PDT 
Created attachment 259340 [details]
it is written
Comment 3 Filip Pizlo 2015-08-18 20:50:32 PDT 
Created attachment 259345 [details]
the patch
Comment 4 WebKit Commit Bot 2015-08-18 20:53:25 PDT 
Attachment 259345 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:81:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Filip Pizlo 2015-08-18 21:21:21 PDT 
Created attachment 259349 [details]
the patch

Fix more builds
Comment 6 WebKit Commit Bot 2015-08-18 21:23:48 PDT 
Attachment 259349 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:82:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Filip Pizlo 2015-08-18 22:01:36 PDT 
Created attachment 259353 [details]
the patch
Comment 8 WebKit Commit Bot 2015-08-18 22:04:32 PDT 
Attachment 259353 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:83:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Geoffrey Garen 2015-08-19 11:06:57 PDT 
Comment on attachment 259353 [details]
the patch

r=me
Comment 10 Filip Pizlo 2015-08-19 11:18:49 PDT 
Landed in http://trac.webkit.org/changeset/188642