Bug 148126 - [EFL] Web Inspector: make to use StringBuilder in inspectorBaseURL
Summary: [EFL] Web Inspector: make to use StringBuilder in inspectorBaseURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Jincheol Jo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-18 04:40 PDT by Jincheol Jo
Modified: 2015-08-18 21:23 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2015-08-18 04:48 PDT, Jincheol Jo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jincheol Jo 2015-08-18 04:40:32 PDT 
It returns chararacters array in WebInspectorProxy::inspectorBaseURL.
So I made to use StringBuilder like the others of WebInspectorProxy.
Comment 1 Jincheol Jo 2015-08-18 04:48:41 PDT 
Created attachment 259262 [details]
Patch
Comment 2 Gyuyoung Kim 2015-08-18 06:17:00 PDT 
Comment on attachment 259262 [details]
Patch

There is no big benefit when using StringBuilder in this case though, it looks this patch is to be aligned with other similar EFL inspector functions.
Comment 3 WebKit Commit Bot 2015-08-18 21:23:24 PDT 
Comment on attachment 259262 [details]
Patch

Clearing flags on attachment: 259262

Committed r188625: <http://trac.webkit.org/changeset/188625>
Comment 4 WebKit Commit Bot 2015-08-18 21:23:28 PDT 
All reviewed patches have been landed.  Closing bug.