Bug 148119 - [Cocoa] Honor the 'trak' table by opting in via text-rendering: optimizeLegibility
Summary: [Cocoa] Honor the 'trak' table by opting in via text-rendering: optimizeLegib...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-17 20:53 PDT by Myles C. Maxfield
Modified: 2015-12-07 16:10 PST (History)
9 users (show)

See Also:


Attachments
Patch (24.05 KB, patch)
2015-08-17 20:59 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (27.03 KB, patch)
2015-08-17 21:27 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (28.76 KB, patch)
2015-08-17 21:40 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (29.77 KB, patch)
2015-08-17 21:44 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (29.72 KB, patch)
2015-08-17 21:50 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (30.13 KB, patch)
2015-08-17 22:54 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (30.32 KB, patch)
2015-08-18 00:10 PDT, Myles C. Maxfield
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-08-17 20:53:09 PDT
[Cocoa] Honor the 'trak' table by opting in via text-rendering: optimizeLegibility
Comment 1 Myles C. Maxfield 2015-08-17 20:59:57 PDT
Created attachment 259234 [details]
Patch
Comment 2 Myles C. Maxfield 2015-08-17 21:00:35 PDT
<rdar://problem/22291561>
Comment 3 Myles C. Maxfield 2015-08-17 21:27:10 PDT
Created attachment 259238 [details]
Patch
Comment 4 Myles C. Maxfield 2015-08-17 21:40:52 PDT
Created attachment 259241 [details]
Patch
Comment 5 Myles C. Maxfield 2015-08-17 21:44:58 PDT
Created attachment 259242 [details]
Patch
Comment 6 Myles C. Maxfield 2015-08-17 21:50:07 PDT
Created attachment 259244 [details]
Patch
Comment 7 Myles C. Maxfield 2015-08-17 22:54:10 PDT
Created attachment 259251 [details]
Patch
Comment 8 Myles C. Maxfield 2015-08-18 00:10:14 PDT
Created attachment 259257 [details]
Patch
Comment 9 Tim Horton 2015-08-18 10:05:05 PDT
Comment on attachment 259257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259257&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:154
> +    RetainPtr<CFDictionaryRef> dictionary;

"dictionary"? maybe a better name here. "attributes"?

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:158
> +        CFTypeRef keys[] = { kCTFontFeatureSettingsAttribute, kCTFontOpticalSizeAttribute };

I assume the reason for all the duplication here (instead of building up the dictionary) is performance, or something? Is this hot code? You could definitely make this more readable/less full of duplicated code.
Comment 10 Myles C. Maxfield 2015-08-18 12:19:58 PDT
Committed r188591: <http://trac.webkit.org/changeset/188591>
Comment 11 Myles C. Maxfield 2015-08-18 14:45:38 PDT
Committed r188597: <http://trac.webkit.org/changeset/188597>
Comment 12 Myles C. Maxfield 2015-08-20 20:20:28 PDT
Also http://trac.webkit.org/changeset/188743
Comment 13 Myles C. Maxfield 2015-12-07 16:05:29 PST
Removing Mavericks-specific lines from platform/mac/TestExpecations due to no longer supporting Mavericks.
Comment 14 Myles C. Maxfield 2015-12-07 16:10:48 PST
Committed r193663: <http://trac.webkit.org/changeset/193663>