Bug 148107 - Web Inspector: shadow visual sidebar section can be confused with the box shadow section
Summary: Web Inspector: shadow visual sidebar section can be confused with the box sha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: EasyFix, InRadar
Depends on:
Blocks: 147563
  Show dependency tree / graph
 
Reported: 2015-08-17 16:57 PDT by Timothy Hatcher
Modified: 2016-01-01 21:53 PST (History)
9 users (show)

See Also:

Attachments
Screenshot (22.64 KB, image/png)
2015-08-17 16:57 PDT, Timothy Hatcher 		no flags Details
Patch (2.45 KB, patch)
2015-12-31 18:09 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-08-17 16:57:07 PDT 
Created attachment 259209 [details]
Screenshot

The data grid and some other controls are sometimes missing from the Shadow section. Switch elements and back sometimes fixes it. No errors in the Inspector's console.
Comment 1 Radar WebKit Bug Importer 2015-08-17 16:57:29 PDT 
<rdar://problem/22317382>
Comment 2 Timothy Hatcher 2015-08-17 16:58:39 PDT 
Oh, this is text-shadow, not box-shadow. That explains it. Maybe the section needs renamed? Even though it is in the Text section. Hmm..
Comment 3 Devin Rousso 2015-08-17 18:10:45 PDT 
(In reply to comment #2)
> Oh, this is text-shadow, not box-shadow. That explains it. Maybe the section
> needs renamed? Even though it is in the Text section. Hmm..

Yeah I can see how someone may get confused between the two.  I'm not really sure what to rename it to, but I'll think about it.
Comment 4 Devin Rousso 2015-12-31 18:09:04 PST 
Created attachment 268062 [details]
Patch
Comment 5 BJ Burg 2016-01-01 19:49:12 PST 
Comment on attachment 268062 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2016-01-01 21:53:21 PST 
Comment on attachment 268062 [details]
Patch

Clearing flags on attachment: 268062

Committed r194491: <http://trac.webkit.org/changeset/194491>
Comment 7 WebKit Commit Bot 2016-01-01 21:53:24 PST 
All reviewed patches have been landed.  Closing bug.