Bug 148079 – Web Inspector: InspectorTest should be a subclass of TestHarness

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

,

[Radar WebKit Bug Importer]

<rdar://problem/22308113>

[Blaze Burg]

Created attachment 259168 [details]
Proposed Fix

[Blaze Burg]

Created attachment 259194 [details]
Proposed Fix (EWS)

[Matt Baker]

Comment on attachment 259194 [details]
Proposed Fix (EWS)

View in context: https://bugs.webkit.org/attachment.cgi?id=259194&action=review

> Source/WebInspectorUI/UserInterface/Test.html:150
> +        // Not reliable unless console messages are dumped to stderr. See wiki for details.

Is there a wiki link that could be added here?

[WebKit Commit Bot]

Comment on attachment 259194 [details]
Proposed Fix (EWS)

Clearing flags on attachment: 259194

Committed r188552: <http://trac.webkit.org/changeset/188552>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 148122

[Alexey Proskuryakov]

Rolled out because this depended on r188539.

[Blaze Burg]

Created attachment 259376 [details]
Proposed Fix (arrow it)

[Timothy Hatcher]

Comment on attachment 259376 [details]
Proposed Fix (arrow it)

View in context: https://bugs.webkit.org/attachment.cgi?id=259376&action=review

> Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js:123
> +            return () => { this.addResult(type + ": " + Array.from(arguments).join(" ")); };

``

> LayoutTests/inspector/debugger/breakpoint-action-eval.html:16
> +    TestPage.addResult("Breakpoint action evaluated. a:(" + a + ") b:(" + b + ")");

``

> LayoutTests/inspector/debugger/resources/script-for-breakpoint-actions.js:4
> +    TestPage.addResult("inside breakpointActions a:(" + a + ") b:(" + b + ")");

``

> LayoutTests/inspector/timeline/debugger-paused-while-recording.html:18
> +    TestPage.addResult("Calling add(): " + a + " + " + b);

``

> LayoutTests/inspector/timeline/debugger-paused-while-recording.html:24
> +    TestPage.addResult("Calling mul(): " + a + " * " + b);

``

> LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html:18
> +    TestPage.addResult("Calling add(): " + a + " + " + b);

``

> LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html:24
> +    TestPage.addResult("Calling mul(): " + a + " * " + b);

``

[Blaze Burg]

Committed r188644: <http://trac.webkit.org/changeset/188644>