Bug 148079 - Web Inspector: InspectorTest should be a subclass of TestHarness
Summary: Web Inspector: InspectorTest should be a subclass of TestHarness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on: 148122
Blocks: 147934
  Show dependency tree / graph
 
Reported: 2015-08-17 09:22 PDT by BJ Burg
Modified: 2022-03-01 02:46 PST (History)
8 users (show)

See Also:

Attachments
Proposed Fix (29.21 KB, patch)
2015-08-17 11:49 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
Proposed Fix (EWS) (29.49 KB, patch)
2015-08-17 15:05 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
Proposed Fix (arrow it) (35.29 KB, patch)
2015-08-19 10:34 PDT, BJ Burg 		timothy: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-08-17 09:22:13 PDT 
,
Comment 1 Radar WebKit Bug Importer 2015-08-17 09:22:28 PDT 
<rdar://problem/22308113>
Comment 2 BJ Burg 2015-08-17 11:49:12 PDT 
Created attachment 259168 [details]
Proposed Fix
Comment 3 BJ Burg 2015-08-17 15:05:28 PDT 
Created attachment 259194 [details]
Proposed Fix (EWS)
Comment 4 Matt Baker 2015-08-17 15:21:02 PDT 
Comment on attachment 259194 [details]
Proposed Fix (EWS)

View in context: https://bugs.webkit.org/attachment.cgi?id=259194&action=review

> Source/WebInspectorUI/UserInterface/Test.html:150
> +        // Not reliable unless console messages are dumped to stderr. See wiki for details.

Is there a wiki link that could be added here?
Comment 5 WebKit Commit Bot 2015-08-17 16:37:12 PDT 
Comment on attachment 259194 [details]
Proposed Fix (EWS)

Clearing flags on attachment: 259194

Committed r188552: <http://trac.webkit.org/changeset/188552>
Comment 6 WebKit Commit Bot 2015-08-17 16:37:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2015-08-17 23:29:49 PDT 
Re-opened since this is blocked by bug 148122
Comment 8 Alexey Proskuryakov 2015-08-17 23:35:52 PDT 
Rolled out because this depended on r188539.
Comment 9 BJ Burg 2015-08-19 10:34:01 PDT 
Created attachment 259376 [details]
Proposed Fix (arrow it)
Comment 10 Timothy Hatcher 2015-08-19 11:53:03 PDT 
Comment on attachment 259376 [details]
Proposed Fix (arrow it)

View in context: https://bugs.webkit.org/attachment.cgi?id=259376&action=review

> Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js:123
> +            return () => { this.addResult(type + ": " + Array.from(arguments).join(" ")); };

``

> LayoutTests/inspector/debugger/breakpoint-action-eval.html:16
> +    TestPage.addResult("Breakpoint action evaluated. a:(" + a + ") b:(" + b + ")");

``

> LayoutTests/inspector/debugger/resources/script-for-breakpoint-actions.js:4
> +    TestPage.addResult("inside breakpointActions a:(" + a + ") b:(" + b + ")");

``

> LayoutTests/inspector/timeline/debugger-paused-while-recording.html:18
> +    TestPage.addResult("Calling add(): " + a + " + " + b);

``

> LayoutTests/inspector/timeline/debugger-paused-while-recording.html:24
> +    TestPage.addResult("Calling mul(): " + a + " * " + b);

``

> LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html:18
> +    TestPage.addResult("Calling add(): " + a + " + " + b);

``

> LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html:24
> +    TestPage.addResult("Calling mul(): " + a + " * " + b);

``
Comment 11 BJ Burg 2015-08-19 12:09:47 PDT 
Committed r188644: <http://trac.webkit.org/changeset/188644>