Bug 148073 – Fix conversion-null warning in conversion.cpp of TestWebKitAPI

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Gyuyoung Kim]

When building EFL port, there is conversion-null build warning.


[5131/5306] Building CXX object Tools/TestWebKitAPI/CMakeFiles/TestWTF.dir/Tests/WTF/Condition.cpp.o
../../Tools/TestWebKitAPI/Tests/WTF/Condition.cpp: In member function ‘virtual void TestWebKitAPI::WTF_Condition_TimeoutTimesOut_Test::TestBody()’:
../../Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:253:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null]
     EXPECT_EQ(false, result);
                                                                                                                                                              ^
[5306/5306] Linking CXX executable bin/TestWebKitAPI/WebKit2/WillSendSubmitEvent

[Gyuyoung Kim]

Created attachment 259134 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 259134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259134&action=review

> Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:253
> -    EXPECT_EQ(false, result);
> +    EXPECT_EQ(result, false);

According to documentation, the order is correct: EXPECT_EQ(expected, actual). This needs a different fix.

[Gyuyoung Kim]

Created attachment 259258 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #2)
> Comment on attachment 259134 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259134&action=review
> 
> > Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:253
> > -    EXPECT_EQ(false, result);
> > +    EXPECT_EQ(result, false);
> 
> According to documentation, the order is correct: EXPECT_EQ(expected,
> actual). This needs a different fix.

Yes, we should use EXPECT_FALSE|TRUE when checking boolean instead of EXPECT_EQ.

[WebKit Commit Bot]

Comment on attachment 259258 [details]
Patch

Clearing flags on attachment: 259258

Committed r188618: <http://trac.webkit.org/changeset/188618>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.