Bug 148068 - will-change should trigger stacking context based purely on properties
Summary: will-change should trigger stacking context based purely on properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-16 12:21 PDT by Simon Fraser (smfr)
Modified: 2015-10-12 11:12 PDT (History)
11 users (show)

See Also:

Attachments
Patch (11.90 KB, patch)
2015-10-06 21:54 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (12.92 KB, patch)
2015-10-06 21:57 PDT, Simon Fraser (smfr) 		zalan: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (644.41 KB, application/zip)
2015-10-06 22:34 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (708.85 KB, application/zip)
2015-10-06 22:40 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-08-16 12:21:19 PDT 
I think will-change should only trigger stacking context when the element supports the changing property.

For example, will-change:transform should be a no-op on a <span>

It's not clear what <div style="will-change:z-index"> should do.
Comment 1 Simon Fraser (smfr) 2015-08-16 12:23:35 PDT 
Started a thread here:
https://lists.w3.org/Archives/Public/www-style/2015Aug/0142.html
Comment 2 Simon Fraser (smfr) 2015-10-04 17:05:27 PDT 
CSSWG disagreed.
Comment 3 Radar WebKit Bug Importer 2015-10-06 00:49:32 PDT 
<rdar://problem/22986868>
Comment 4 Simon Fraser (smfr) 2015-10-06 21:54:28 PDT 
Created attachment 262579 [details]
Patch
Comment 5 Simon Fraser (smfr) 2015-10-06 21:57:31 PDT 
Created attachment 262581 [details]
Patch
Comment 6 Build Bot 2015-10-06 22:34:23 PDT 
Comment on attachment 262581 [details]
Patch

Attachment 262581 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/252843

New failing tests:
fast/css/will-change/will-change-creates-stacking-context-inline.html
Comment 7 Build Bot 2015-10-06 22:34:26 PDT 
Created attachment 262582 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 8 Build Bot 2015-10-06 22:40:47 PDT 
Comment on attachment 262581 [details]
Patch

Attachment 262581 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/252849

New failing tests:
fast/css/will-change/will-change-creates-stacking-context-inline.html
Comment 9 Build Bot 2015-10-06 22:40:50 PDT 
Created attachment 262583 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 10 Simon Fraser (smfr) 2015-10-07 08:10:24 PDT 
https://trac.webkit.org/changeset/190667
Comment 11 Alexey Proskuryakov 2015-10-07 21:57:09 PDT 
fast/css/will-change/will-change-creates-stacking-context-inline.html fails on Windows too (of course).

Could you please add an expectation?
Comment 12 Brent Fulgham 2015-10-12 11:12:25 PDT 
Test expectation for expected Windows failure (due to lack of backdrop-filter support) committed:

https://trac.webkit.org/changeset/190868.