Bug 148065 - Holes for find matches that span multiple lines are completely wrong
Summary: Holes for find matches that span multiple lines are completely wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-16 01:51 PDT by Tim Horton
Modified: 2015-08-17 11:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.95 KB, patch)
2015-08-16 01:52 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (8.87 KB, patch)
2015-08-16 01:57 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (8.90 KB, patch)
2015-08-16 02:03 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-08-16 01:51:44 PDT 
Holes for find matches that span multiple lines are completely wrong
Comment 1 Tim Horton 2015-08-16 01:52:14 PDT 
Created attachment 259118 [details]
Patch
Comment 2 Tim Horton 2015-08-16 01:57:19 PDT 
Created attachment 259119 [details]
Patch
Comment 3 Tim Horton 2015-08-16 02:02:05 PDT 
<rdar://problem/5305002>
Comment 4 Tim Horton 2015-08-16 02:03:18 PDT 
Created attachment 259120 [details]
Patch
Comment 5 Simon Fraser (smfr) 2015-08-17 10:39:51 PDT 
Comment on attachment 259120 [details]
Patch

We should add a way to test DocumentMarkers.
Comment 6 Tim Horton 2015-08-17 10:52:35 PDT 
(In reply to comment #5)
> Comment on attachment 259120 [details]
> Patch
> 
> We should add a way to test DocumentMarkers.

There is apparently a mechanism in Internals, so I'm going to try to write a test before landing.
Comment 7 Tim Horton 2015-08-17 11:12:32 PDT 
With a test!: http://trac.webkit.org/changeset/188527