RESOLVED FIXED 148046
Clean up js-test use in scroll-snap tests 
https://bugs.webkit.org/show_bug.cgi?id=148046
Summary Clean up js-test use in scroll-snap tests
Alexey Proskuryakov
Reported 2015-08-14 16:41:30 PDT
Some of the tests have misplaced "TEST COMPLETE" output lines and other minor issues.
Attachments
proposed patch (29.73 KB, patch)
2015-08-14 16:42 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-08-14 16:42:53 PDT
Created attachment 259057 [details] proposed patch
Brent Fulgham
Comment 2 2015-08-14 20:38:57 PDT
Comment on attachment 259057 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=259057&action=review Thank you for cleaning these up! r=me. > LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders-expected.txt:2 > + Testing scroll-snap glide for horizontalTarget: I wonder why there is this extra space here?
Alexey Proskuryakov
Comment 3 2015-08-14 22:06:49 PDT
Comment on attachment 259057 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=259057&action=review >> LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders-expected.txt:2 >> + Testing scroll-snap glide for horizontalTarget: > > I wonder why there is this extra space here? There was already a space in the first output line (" PASS successfullyParsed is true"), so it's not a regression from this patch. It comes from a div, although I'm not entirely sure why WebCore decides to serialize in div into a space. I agree that this looks weird.
WebKit Commit Bot
Comment 4 2015-08-14 22:51:28 PDT
Comment on attachment 259057 [details] proposed patch Clearing flags on attachment: 259057 Committed r188509: <http://trac.webkit.org/changeset/188509>
WebKit Commit Bot
Comment 5 2015-08-14 22:51:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.