Bug 148046 - Clean up js-test use in scroll-snap tests
Summary: Clean up js-test use in scroll-snap tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-14 16:41 PDT by Alexey Proskuryakov
Modified: 2015-08-14 22:51 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (29.73 KB, patch)
2015-08-14 16:42 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-08-14 16:41:30 PDT
Some of the tests have misplaced "TEST COMPLETE" output lines and other minor issues.
Comment 1 Alexey Proskuryakov 2015-08-14 16:42:53 PDT
Created attachment 259057 [details]
proposed patch
Comment 2 Brent Fulgham 2015-08-14 20:38:57 PDT
Comment on attachment 259057 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259057&action=review

Thank you for cleaning these up! r=me.

> LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders-expected.txt:2
> + Testing scroll-snap glide for horizontalTarget:

I wonder why there is this extra space here?
Comment 3 Alexey Proskuryakov 2015-08-14 22:06:49 PDT
Comment on attachment 259057 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259057&action=review

>> LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders-expected.txt:2
>> + Testing scroll-snap glide for horizontalTarget:
> 
> I wonder why there is this extra space here?

There was already a space in the first output line (" PASS successfullyParsed is true"), so it's not a regression from this patch. It comes from a div, although I'm not entirely sure why WebCore decides to serialize in div into a space.

I agree that this looks weird.
Comment 4 WebKit Commit Bot 2015-08-14 22:51:28 PDT
Comment on attachment 259057 [details]
proposed patch

Clearing flags on attachment: 259057

Committed r188509: <http://trac.webkit.org/changeset/188509>
Comment 5 WebKit Commit Bot 2015-08-14 22:51:32 PDT
All reviewed patches have been landed.  Closing bug.