RESOLVED FIXED 148038
cryptographicallyRandomValuesFromOS should use arc4random_buf on Darwin. 
https://bugs.webkit.org/show_bug.cgi?id=148038
Summary cryptographicallyRandomValuesFromOS should use arc4random_buf on Darwin.
Keith Miller
Reported 2015-08-14 13:39:55 PDT
Currently, we open a file descriptor to /dev/urandom, which can sometimes fail to open. Using arc4random_buf instead should get around this issue.
Attachments
Patch (2.09 KB, patch)
2015-08-14 13:42 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2015-08-14 13:42:53 PDT
Created attachment 259034 [details] Patch
Geoffrey Garen
Comment 2 2015-08-14 14:17:38 PDT
Comment on attachment 259034 [details] Patch r=me
WebKit Commit Bot
Comment 3 2015-08-14 15:01:58 PDT
Comment on attachment 259034 [details] Patch Clearing flags on attachment: 259034 Committed r188489: <http://trac.webkit.org/changeset/188489>
WebKit Commit Bot
Comment 4 2015-08-14 15:02:02 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2015-08-15 13:13:35 PDT
This is a pretty surprising change. How did you come to this conclusion, and what other options have you considered? Is there even a bug anywhere tracking the symptom? More specifically, how did you decide to not use CCRandomCopyBytes, and what can make opening /dev/urandom fail?
Keith Miller
Comment 6 2015-08-17 11:50:29 PDT
Whoops, I forgot to attach the associated radar (rdar://problem/21939126) to this bug. Alexey, I chose to use arc4random_buf because we just needed something that didn't open /dev/urandom. Although, looking into arc4random_buf further it appears that it opens /dev/urandom anyway.
Alexey Proskuryakov
Comment 7 2015-08-17 11:56:33 PDT
Thank you for the link! > Although, looking into arc4random_buf further it appears that it opens /dev/urandom anyway. Should the patch be rolled out then?
Keith Miller
Comment 8 2015-08-17 16:07:46 PDT
> Should the patch be rolled out then? I'm not sure it's worth it. I am finishing up a patch that uses CCRandomCopyBytes instead. I'll CC you on that.
Note You need to log in before you can comment on or make changes to this bug.