Bug 148037 – Web Inspector: add support for running protocol-test.js tests on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

We currently don't implement TestRunner::inspectorTestStubURL() for Windows, so tests that use `protocol-test.js` cannot load the stub inspector frontend into an iframe.

[Radar WebKit Bug Importer]

<rdar://problem/22292237>

[Brent Fulgham]

This is the cause of 'fast/dom/Window/property-access-on-cached-window-after-frame-removed.html' failing on Win

[Brent Fulgham]

*** Bug 151759 has been marked as a duplicate of this bug. ***

[Brent Fulgham]

Created attachment 267856 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 267856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267856&action=review

> Tools/DumpRenderTree/win/TestRunnerWin.cpp:1106
> +    CFStringRef urlString = CFURLGetString(url.get());

You could lose this local variable.

[Brent Fulgham]

(In reply to comment #5)
> Comment on attachment 267856 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267856&action=review
> 
> > Tools/DumpRenderTree/win/TestRunnerWin.cpp:1106
> > +    CFStringRef urlString = CFURLGetString(url.get());
> 
> You could lose this local variable.

Oh -- good idea!

[Brent Fulgham]

Looks like this requires a clean build on Windows. :-(

[Brent Fulgham]

Committed r194398: <http://trac.webkit.org/changeset/194398>