Bug 148037 - Web Inspector: add support for running protocol-test.js tests on Windows
Summary: Web Inspector: add support for running protocol-test.js tests on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
: 151759 (view as bug list)
Depends on:
Blocks: 137157 InspectorTest
  Show dependency tree / graph
 
Reported: 2015-08-14 13:17 PDT by BJ Burg
Modified: 2015-12-23 15:25 PST (History)
10 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2015-12-23 14:28 PST, Brent Fulgham 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-08-14 13:17:03 PDT 
We currently don't implement TestRunner::inspectorTestStubURL() for Windows, so tests that use `protocol-test.js` cannot load the stub inspector frontend into an iframe.
Comment 1 Radar WebKit Bug Importer 2015-08-14 13:17:39 PDT 
<rdar://problem/22292237>
Comment 2 Brent Fulgham 2015-12-23 12:48:32 PST 
This is the cause of 'fast/dom/Window/property-access-on-cached-window-after-frame-removed.html' failing on Win
Comment 3 Brent Fulgham 2015-12-23 12:49:05 PST 
*** Bug 151759 has been marked as a duplicate of this bug. ***
Comment 4 Brent Fulgham 2015-12-23 14:28:19 PST 
Created attachment 267856 [details]
Patch
Comment 5 Simon Fraser (smfr) 2015-12-23 14:37:57 PST 
Comment on attachment 267856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267856&action=review

> Tools/DumpRenderTree/win/TestRunnerWin.cpp:1106
> +    CFStringRef urlString = CFURLGetString(url.get());

You could lose this local variable.
Comment 6 Brent Fulgham 2015-12-23 14:40:29 PST 
(In reply to comment #5)
> Comment on attachment 267856 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267856&action=review
> 
> > Tools/DumpRenderTree/win/TestRunnerWin.cpp:1106
> > +    CFStringRef urlString = CFURLGetString(url.get());
> 
> You could lose this local variable.

Oh -- good idea!
Comment 7 Brent Fulgham 2015-12-23 15:18:31 PST 
Looks like this requires a clean build on Windows. :-(
Comment 8 Brent Fulgham 2015-12-23 15:25:49 PST 
Committed r194398: <http://trac.webkit.org/changeset/194398>