RESOLVED FIXED 148004
Remove a few includes from JSGlobalObject.h 
https://bugs.webkit.org/show_bug.cgi?id=148004
Summary Remove a few includes from JSGlobalObject.h
Simon Fraser (smfr)
Reported 2015-08-13 17:40:42 PDT
Remove a few includes from JSGlobalObject.h
Attachments
Patch (4.06 KB, patch)
2015-08-13 17:41 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (6.32 KB, patch)
2015-10-05 16:57 PDT, Geoffrey Garen 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-08-13 17:41:27 PDT
Created attachment 258961 [details] Patch
WebKit Commit Bot
Comment 2 2015-08-13 19:36:45 PDT
Comment on attachment 258961 [details] Patch Clearing flags on attachment: 258961 Committed r188431: <http://trac.webkit.org/changeset/188431>
WebKit Commit Bot
Comment 3 2015-08-13 19:36:48 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 4 2015-08-13 21:35:21 PDT
Re-opened since this is blocked by bug 148013
Simon Fraser (smfr)
Comment 5 2015-08-13 21:36:40 PDT
Geoff/Filip: can someone help me land this? I wasn't able to figure out the right #includes to get Debug building.
Geoffrey Garen
Comment 7 2015-08-18 15:17:05 PDT
Looks like StructureRareDataInlines.h needs to #include JSString.h.
Simon Fraser (smfr)
Comment 8 2015-10-04 17:07:04 PDT
Phil, anything useful here?
Geoffrey Garen
Comment 9 2015-10-05 16:57:41 PDT
Created attachment 262480 [details] Patch
Saam Barati
Comment 10 2015-10-05 17:22:58 PDT
Comment on attachment 262480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262480&action=review r=me > Source/JavaScriptCore/runtime/JSGlobalObject.h:81 > +class NullGetterFunction; Duplicate > Source/JavaScriptCore/runtime/JSGlobalObject.h:83 > +class NullSetterFunction; Duplicate
Geoffrey Garen
Comment 11 2015-10-05 18:59:29 PDT
Committed r190601: <http://trac.webkit.org/changeset/190601>
Note You need to log in before you can comment on or make changes to this bug.