RESOLVED FIXED 147993
Web Inspector: Skip rendering frame records without children 
https://bugs.webkit.org/show_bug.cgi?id=147993
Summary Web Inspector: Skip rendering frame records without children
Matt Baker
Reported 2015-08-13 14:09:25 PDT
* SUMMARY Skip rendering frame records without children. We currently skip frame record payloads with no children, but the logic for skipping frame model objects with no children is broken.
Attachments
[Patch] Proposed Fix (4.46 KB, patch)
2015-08-13 14:18 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (4.57 KB, patch)
2015-08-13 14:36 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2015-08-13 14:18:44 PDT
Created attachment 258934 [details] [Patch] Proposed Fix
Radar WebKit Bug Importer
Comment 2 2015-08-13 14:18:58 PDT
<rdar://problem/22275866>
Joseph Pecoraro
Comment 3 2015-08-13 14:26:58 PDT
Comment on attachment 258934 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=258934&action=review r=me > Source/WebInspectorUI/UserInterface/Models/RenderingFrameTimelineRecord.js:73 > + if (this._frameIndex >= 0) > + return; > + this._frameIndex = WebInspector.RenderingFrameTimelineRecord._nextFrameIndex++; If we expect this to be set only once, we can: console.assert(this._frameIndex === -1);
Matt Baker
Comment 4 2015-08-13 14:36:22 PDT
Created attachment 258937 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 5 2015-08-13 15:27:56 PDT
Comment on attachment 258937 [details] [Patch] Proposed Fix Clearing flags on attachment: 258937 Committed r188408: <http://trac.webkit.org/changeset/188408>
WebKit Commit Bot
Comment 6 2015-08-13 15:28:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.