Bug 147993 - Web Inspector: Skip rendering frame records without children
Summary: Web Inspector: Skip rendering frame records without children
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-13 14:09 PDT by Matt Baker
Modified: 2015-08-13 15:28 PDT (History)
8 users (show)

See Also:


Attachments
[Patch] Proposed Fix (4.46 KB, patch)
2015-08-13 14:18 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (4.57 KB, patch)
2015-08-13 14:36 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-08-13 14:09:25 PDT
* SUMMARY
Skip rendering frame records without children. We currently skip frame record payloads with no children, but the logic for skipping frame model objects with no children is broken.
Comment 1 Matt Baker 2015-08-13 14:18:44 PDT
Created attachment 258934 [details]
[Patch] Proposed Fix
Comment 2 Radar WebKit Bug Importer 2015-08-13 14:18:58 PDT
<rdar://problem/22275866>
Comment 3 Joseph Pecoraro 2015-08-13 14:26:58 PDT
Comment on attachment 258934 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=258934&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/RenderingFrameTimelineRecord.js:73
> +        if (this._frameIndex >= 0)
> +            return;
> +        this._frameIndex = WebInspector.RenderingFrameTimelineRecord._nextFrameIndex++;

If we expect this to be set only once, we can: console.assert(this._frameIndex === -1);
Comment 4 Matt Baker 2015-08-13 14:36:22 PDT
Created attachment 258937 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2015-08-13 15:27:56 PDT
Comment on attachment 258937 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 258937

Committed r188408: <http://trac.webkit.org/changeset/188408>
Comment 6 WebKit Commit Bot 2015-08-13 15:28:00 PDT
All reviewed patches have been landed.  Closing bug.