RESOLVED FIXED 147982
Remove pixelSnapped* functions from RenderBoxModelObject/RenderBox. 
https://bugs.webkit.org/show_bug.cgi?id=147982
Summary Remove pixelSnapped* functions from RenderBoxModelObject/RenderBox.
zalan
Reported 2015-08-13 10:39:51 PDT
They are highly misleading. (integral vs. device pixel snapping)
Attachments
Patch (53.33 KB, patch)
2015-08-13 11:21 PDT, zalan 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-mavericks (658.87 KB, application/zip)
2015-08-13 12:02 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (632.58 KB, application/zip)
2015-08-13 12:14 PDT, Build Bot 		no flags
Details
Patch (53.38 KB, patch)
2015-08-13 12:25 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (54.14 KB, patch)
2015-08-13 13:17 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (54.15 KB, patch)
2015-08-13 13:37 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (54.16 KB, patch)
2015-08-13 20:08 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2015-08-13 11:21:13 PDT
Created attachment 258903 [details] Patch
Build Bot
Comment 2 2015-08-13 12:02:07 PDT
Comment on attachment 258903 [details] Patch Attachment 258903 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/53734 New failing tests: fast/dom/HTMLImageElement/image-without-renderer-width.html js/dom/custom-constructors.html
Build Bot
Comment 3 2015-08-13 12:02:10 PDT
Created attachment 258909 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 4 2015-08-13 12:14:23 PDT
Comment on attachment 258903 [details] Patch Attachment 258903 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/53781 New failing tests: fast/dom/HTMLImageElement/image-without-renderer-width.html js/dom/custom-constructors.html
Build Bot
Comment 5 2015-08-13 12:14:26 PDT
Created attachment 258913 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
zalan
Comment 6 2015-08-13 12:25:08 PDT
Created attachment 258914 [details] Patch
zalan
Comment 7 2015-08-13 13:17:22 PDT
Created attachment 258921 [details] Patch
zalan
Comment 8 2015-08-13 13:37:35 PDT
Created attachment 258926 [details] Patch
Simon Fraser (smfr)
Comment 9 2015-08-13 16:30:32 PDT
Comment on attachment 258926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258926&action=review > Source/WebCore/html/shadow/SpinButtonElement.cpp:92 > + if (box->borderBoxRect().contains(local)) { In theory event handling should match painting, but in practice it doesn't matter. > Source/WebCore/rendering/RenderBox.h:156 > + virtual IntRect borderBoundingBox() const override final { return snappedIntRect(borderBoxRect()); } Maybe put "snapped" in the name? Maybe remove this entirely.
zalan
Comment 10 2015-08-13 20:08:41 PDT
Created attachment 258972 [details] Patch
WebKit Commit Bot
Comment 11 2015-08-13 21:34:55 PDT
Comment on attachment 258972 [details] Patch Clearing flags on attachment: 258972 Committed r188433: <http://trac.webkit.org/changeset/188433>
WebKit Commit Bot
Comment 12 2015-08-13 21:34:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.