Bug 147971 - REGRESSION (r188325): Web Inspector: Fix vertical spacing in CodeMirror
Summary: REGRESSION (r188325): Web Inspector: Fix vertical spacing in CodeMirror
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-12 23:19 PDT by Nikita Vasilyev
Modified: 2015-08-13 04:50 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2015-08-13 00:22 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-08-12 23:19:00 PDT 
Via https://bugs.webkit.org/show_bug.cgi?id=147109#c10
Comment 1 Nikita Vasilyev 2015-08-12 23:40:23 PDT 
    .CodeMirror pre {
        line-height: inherit;
    }

Computed line-height for ".CodeMirror pre" has changed from 11px to 13px. Our new jump to definition feature isn't helpful here — it just highlights "line-height: inherit;".
Comment 2 Nikita Vasilyev 2015-08-12 23:53:48 PDT 
https://github.com/WebKit/webkit/commit/860334772804d47022a6cbdafd633449fb0d124c#diff-e529b55c5da3924f8dedf9a33ba0708bL112

    .CodeMirror {
   -  line-height: 1;

This caused the change in the line-height from 11 to 13px.
Comment 3 Nikita Vasilyev 2015-08-13 00:22:31 PDT 
Created attachment 258883 [details]
Patch
Comment 4 WebKit Commit Bot 2015-08-13 04:50:06 PDT 
Comment on attachment 258883 [details]
Patch

Clearing flags on attachment: 258883

Committed r188382: <http://trac.webkit.org/changeset/188382>
Comment 5 WebKit Commit Bot 2015-08-13 04:50:09 PDT 
All reviewed patches have been landed.  Closing bug.