RESOLVED FIXED 147971
REGRESSION (r188325): Web Inspector: Fix vertical spacing in CodeMirror 
https://bugs.webkit.org/show_bug.cgi?id=147971
Summary REGRESSION (r188325): Web Inspector: Fix vertical spacing in CodeMirror
Nikita Vasilyev
Reported 2015-08-12 23:19:00 PDT
Via https://bugs.webkit.org/show_bug.cgi?id=147109#c10
Attachments
Patch (1.46 KB, patch)
2015-08-13 00:22 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2015-08-12 23:40:23 PDT
.CodeMirror pre { line-height: inherit; } Computed line-height for ".CodeMirror pre" has changed from 11px to 13px. Our new jump to definition feature isn't helpful here — it just highlights "line-height: inherit;".
Nikita Vasilyev
Comment 2 2015-08-12 23:53:48 PDT
https://github.com/WebKit/webkit/commit/860334772804d47022a6cbdafd633449fb0d124c#diff-e529b55c5da3924f8dedf9a33ba0708bL112 .CodeMirror { - line-height: 1; This caused the change in the line-height from 11 to 13px.
Nikita Vasilyev
Comment 3 2015-08-13 00:22:31 PDT
Created attachment 258883 [details] Patch
WebKit Commit Bot
Comment 4 2015-08-13 04:50:06 PDT
Comment on attachment 258883 [details] Patch Clearing flags on attachment: 258883 Committed r188382: <http://trac.webkit.org/changeset/188382>
WebKit Commit Bot
Comment 5 2015-08-13 04:50:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.