Bug 147970 - FilterOperation.h should not include FilterEffect.h
Summary: FilterOperation.h should not include FilterEffect.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-12 23:15 PDT by Simon Fraser (smfr)
Modified: 2016-03-28 10:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.14 KB, patch)
2015-08-12 23:17 PDT, Simon Fraser (smfr) 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-08-12 23:15:38 PDT 
FilterOperation.h should not include FilterEffect.h
Comment 1 Simon Fraser (smfr) 2015-08-12 23:17:04 PDT 
Created attachment 258880 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-08-13 00:02:49 PDT 
iOS is red.
Comment 3 Daniel Bates 2015-08-13 09:31:39 PDT 
Comment on attachment 258880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258880&action=review

> Source/WebCore/platform/graphics/filters/FilterOperation.cpp:69
> +void ReferenceFilterOperation::setFilterEffect(PassRefPtr<FilterEffect> filterEffect)

We should change PassRefPtr<> to RefPtr<>&&. This can be done in a separate bug.
Comment 4 Simon Fraser (smfr) 2015-08-13 16:16:20 PDT 
http://trac.webkit.org/changeset/188389
Comment 5 Csaba Osztrogonác 2015-08-14 13:17:49 PDT 
(In reply to comment #4)
> http://trac.webkit.org/changeset/188389

It broke the EFL build.