Bug 14797 - [gtk] Make GraphicsContext use a full GdkEventExpose* to ease implementing Widget::paint
Summary: [gtk] Make GraphicsContext use a full GdkEventExpose* to ease implementing Wi...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 14781
Blocks:
  Show dependency treegraph
 
Reported: 2007-07-27 20:06 PDT by Holger Freyther
Modified: 2007-08-09 17:47 PDT (History)
0 users

See Also:


Attachments
Store GdkEventExpose* in GraphicsContext and implement Widget::paint (4.66 KB, patch)
2007-07-27 20:11 PDT, Holger Freyther
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2007-07-27 20:06:45 PDT
To implement Widget::paint we need to paint at the moment RenderWidget is going to request painting. To ease that we will store the full GdkEventExpose inside the GraphicsContext. And create a synthetic GdkEvent and ask gtkWidget to paint, this should be roughly similiar to how GtkContainer is handling exposing of children and will continue to work once we have multiple frames in Gtk as well.
Comment 1 Holger Freyther 2007-07-27 20:11:31 PDT
Created attachment 15715 [details]
Store GdkEventExpose* in GraphicsContext and implement Widget::paint

-No ChangeLog entry as it requires 14781
-This is a patch from git and won't apply with svn-apply

-setGdkExposeEvent matches the Qt naming of such methods (e.g. mousePressEvent,...) but the parameter has it reversed with GdkEventExpose. I think the way I named the method follows the WebCore naming style and is the way to go.
-I ignore the clip rect of Widget::paint but that should directly come from the expose event anyway.
Comment 2 Holger Freyther 2007-07-30 12:44:40 PDT
#14729 has this part included as well. 
Comment 3 Alp Toker 2007-08-01 20:16:52 PDT
Comment on attachment 15715 [details]
Store GdkEventExpose* in GraphicsContext and implement Widget::paint

Seems to be obsoleted by http://bugs.webkit.org/attachment.cgi?id=15794