Bug 147969 - ScriptExecutionContext.h pulls in all the JSC headers
Summary: ScriptExecutionContext.h pulls in all the JSC headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 147967
  Show dependency tree / graph
 
Reported: 2015-08-12 22:32 PDT by Simon Fraser (smfr)
Modified: 2015-08-13 18:12 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.81 KB, patch)
2015-08-12 22:34 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
RenderBlock.d diff with the change (44.32 KB, text/plain)
2015-08-12 22:35 PDT, Simon Fraser (smfr) 		no flags Details
Patch (5.37 KB, patch)
2015-08-13 09:53 PDT, Simon Fraser (smfr) 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-08-12 22:32:59 PDT 
ScriptExecutionContext.h pulls in all the JSC headers
Comment 1 Simon Fraser (smfr) 2015-08-12 22:34:58 PDT 
Created attachment 258877 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-08-12 22:35:56 PDT 
Created attachment 258878 [details]
RenderBlock.d diff with the change
Comment 3 Alexey Proskuryakov 2015-08-12 23:13:20 PDT 
Looks like some of the *Inlines.h headers need to be re-added to .cpp files.
Comment 4 Simon Fraser (smfr) 2015-08-12 23:18:09 PDT 
Hmm this built for me locally, in Debug.
Comment 5 Alexey Proskuryakov 2015-08-13 00:01:46 PDT 
Yes, that's expected I think - in Debug, inlines are not inlined, so the linker has a copy to use that was generated in some other compilation unit.
Comment 6 Simon Fraser (smfr) 2015-08-13 09:53:41 PDT 
Created attachment 258893 [details]
Patch
Comment 7 Alexey Proskuryakov 2015-08-13 11:28:31 PDT 
Comment on attachment 258893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258893&action=review

> Source/WebCore/Modules/webdatabase/SQLTransaction.h:33
> +#include "EventTarget.h"
>  #include "SQLCallbackWrapper.h"

Out of order
Comment 8 Brent Fulgham 2015-08-13 12:28:53 PDT 
This broke the Windows build. :-(
Comment 9 Simon Fraser (smfr) 2015-08-13 18:12:45 PDT 
http://trac.webkit.org/changeset/188388