Bug 147950 - DFG::ByteCodeParser should attempt constant folding on loads from structures that are DFG-watchable
Summary: DFG::ByteCodeParser should attempt constant folding on loads from structures ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-12 13:31 PDT by Filip Pizlo
Modified: 2015-08-12 14:02 PDT (History)
0 users

See Also:

Attachments
the patch (2.67 KB, patch)
2015-08-12 13:38 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-08-12 13:31:29 PDT 
We accidentally broke the ByteCodeParser's constant folding of loads from constants with DFG-watchable structures in http://trac.webkit.org/changeset/188292.  The constant folding would happen later, but there are some constant folding rules that only the ByteCodeParser is capable of, particularly with things like CreateThis.
Comment 1 Filip Pizlo 2015-08-12 13:38:50 PDT 
Created attachment 258842 [details]
the patch
Comment 2 Michael Saboff 2015-08-12 13:41:00 PDT 
Comment on attachment 258842 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-08-12 14:02:04 PDT 
Landed in http://trac.webkit.org/changeset/188357