Bug 147943 - [ES6] Implement Reflect.defineProperty
Summary: [ES6] Implement Reflect.defineProperty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-12 11:36 PDT by Yusuke Suzuki
Modified: 2015-08-12 15:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (13.01 KB, patch)
2015-08-12 11:38 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-08-12 11:36:38 PDT 
[ES6] Implement Reflect.defineProperty
Comment 1 Yusuke Suzuki 2015-08-12 11:38:34 PDT 
Created attachment 258832 [details]
Patch
Comment 2 Saam Barati 2015-08-12 14:00:45 PDT 
Comment on attachment 258832 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258832&action=review

r=me

> Source/JavaScriptCore/runtime/ReflectObject.cpp:88
> +EncodedJSValue JSC_HOST_CALL reflectObjectDefineProperty(ExecState* exec)

A link to the spec here would be nice.
Comment 3 Yusuke Suzuki 2015-08-12 15:25:15 PDT 
Comment on attachment 258832 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258832&action=review

Thank you for your review :)

>> Source/JavaScriptCore/runtime/ReflectObject.cpp:88
>> +EncodedJSValue JSC_HOST_CALL reflectObjectDefineProperty(ExecState* exec)
> 
> A link to the spec here would be nice.

Sounds nice! I'll add it here.
Comment 4 Yusuke Suzuki 2015-08-12 15:59:25 PDT 
Committed r188361: <http://trac.webkit.org/changeset/188361>