Bug 147924 - Web Inspector: Can't resize split console when window is too narrow
Summary: Web Inspector: Can't resize split console when window is too narrow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-11 23:25 PDT by Nikita Vasilyev
Modified: 2015-08-13 23:21 PDT (History)
8 users (show)

See Also:


Attachments
Animated GIF of the problem (478.82 KB, image/gif)
2015-08-11 23:25 PDT, Nikita Vasilyev
no flags Details
Patch (1.56 KB, patch)
2015-08-13 21:35 PDT, Nikita Vasilyev
timothy: review+
Details | Formatted Diff | Diff
[Image] Red - draggable area (32.07 KB, image/png)
2015-08-13 21:39 PDT, Nikita Vasilyev
no flags Details
Patch (1.57 KB, patch)
2015-08-13 22:26 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2015-08-13 22:27 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-08-11 23:25:26 PDT
Created attachment 258808 [details]
Animated GIF of the problem

1. 4 pixels at the top of the split console show allow to resize it.

2. When hovering over the resizer, the empty area between the "Console" label and the "Filter Console Log" search field, mouse cursor should change to up-down arrow (⬍).

3. "Filter Console Log" placeholder text shouldn't be selectable.
Comment 1 Timothy Hatcher 2015-08-11 23:58:05 PDT
Because resizing is on;y allowed on FlexibleSpaceNavigationItems and empty space in the navigation bar. We should fix this.
Comment 2 Nikita Vasilyev 2015-08-13 21:35:07 PDT
Created attachment 258974 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2015-08-13 21:35:23 PDT
<rdar://problem/22282417>
Comment 4 Nikita Vasilyev 2015-08-13 21:39:20 PDT
Created attachment 258977 [details]
[Image] Red - draggable area
Comment 5 Timothy Hatcher 2015-08-13 22:13:32 PDT
Comment on attachment 258974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258974&action=review

> Source/WebInspectorUI/UserInterface/Views/Main.css:177
> +#split-content-browser > .navigation-bar .log-scope-bar {

:matches()

> Source/WebInspectorUI/UserInterface/Views/Main.css:182
> +#split-content-browser > .navigation-bar .log-scope-bar > li {

Ditto.
Comment 6 Nikita Vasilyev 2015-08-13 22:26:42 PDT
Created attachment 258980 [details]
Patch
Comment 7 Nikita Vasilyev 2015-08-13 22:27:59 PDT
Created attachment 258981 [details]
Patch
Comment 8 WebKit Commit Bot 2015-08-13 23:21:26 PDT
Comment on attachment 258981 [details]
Patch

Clearing flags on attachment: 258981

Committed r188442: <http://trac.webkit.org/changeset/188442>
Comment 9 WebKit Commit Bot 2015-08-13 23:21:31 PDT
All reviewed patches have been landed.  Closing bug.