Web Inspector: Disabling attribute styles should not be possible

[Devin Rousso]

Currently, clicking a style icon in the Rules panel adds comments around every line in that style to "disable" that rule.  This should not be possible for any type of style other than inline, author, user, inspector, and inherited rules.  Currently, it allows toggling of everything other than UserAgent, but this needs to be changed to the list above.

[Devin Rousso]

Created attachment 258803 [details]
Patch

[Timothy Hatcher]

Comment on attachment 258803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258803&action=review

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:103
> +        if (style.editable && (style.type === WebInspector.CSSStyleDeclaration.Type.Rule || style.type === WebInspector.CSSStyleDeclaration.Type.Inline)

Would style.editable be enough?

[Devin Rousso]

(In reply to comment #2)
> Comment on attachment 258803 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258803&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:103
> > +        if (style.editable && (style.type === WebInspector.CSSStyleDeclaration.Type.Rule || style.type === WebInspector.CSSStyleDeclaration.Type.Inline)
> 
> Would style.editable be enough?

Ha I can't believe I didn't think of that.  It works exactly as described.

[Devin Rousso]

Created attachment 258805 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 258805 [details]
Patch

Clearing flags on attachment: 258805

Committed r188326: <http://trac.webkit.org/changeset/188326>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.