RESOLVED FIXED 147922
Web Inspector: Disabling attribute styles should not be possible 
https://bugs.webkit.org/show_bug.cgi?id=147922
Summary Web Inspector: Disabling attribute styles should not be possible
Devin Rousso
Reported 2015-08-11 22:05:36 PDT
Currently, clicking a style icon in the Rules panel adds comments around every line in that style to "disable" that rule. This should not be possible for any type of style other than inline, author, user, inspector, and inherited rules. Currently, it allows toggling of everything other than UserAgent, but this needs to be changed to the list above.
Attachments
Patch (2.08 KB, patch)
2015-08-11 22:07 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (1.66 KB, patch)
2015-08-11 22:17 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2015-08-11 22:07:24 PDT
Created attachment 258803 [details] Patch
Timothy Hatcher
Comment 2 2015-08-11 22:10:20 PDT
Comment on attachment 258803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258803&action=review > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:103 > + if (style.editable && (style.type === WebInspector.CSSStyleDeclaration.Type.Rule || style.type === WebInspector.CSSStyleDeclaration.Type.Inline) Would style.editable be enough?
Devin Rousso
Comment 3 2015-08-11 22:16:13 PDT
(In reply to comment #2) > Comment on attachment 258803 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258803&action=review > > > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:103 > > + if (style.editable && (style.type === WebInspector.CSSStyleDeclaration.Type.Rule || style.type === WebInspector.CSSStyleDeclaration.Type.Inline) > > Would style.editable be enough? Ha I can't believe I didn't think of that. It works exactly as described.
Devin Rousso
Comment 4 2015-08-11 22:17:43 PDT
Created attachment 258805 [details] Patch
WebKit Commit Bot
Comment 5 2015-08-11 22:46:10 PDT
Comment on attachment 258805 [details] Patch Clearing flags on attachment: 258805 Committed r188326: <http://trac.webkit.org/changeset/188326>
WebKit Commit Bot
Comment 6 2015-08-11 22:46:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.