Bug 147921 - CSSParserValueList argument should be a reference
Summary: CSSParserValueList argument should be a reference
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-11 21:38 PDT by Gyuyoung Kim
Modified: 2022-07-24 13:51 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.71 KB, patch)
2015-08-11 21:39 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (6.66 KB, patch)
2015-08-11 21:42 PDT, Gyuyoung Kim 		bfulgham: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-08-11 21:38:41 PDT 
Argument of CSSParserValueList has been treated as it is non-null pointer. So it should be a reference.
Comment 1 Gyuyoung Kim 2015-08-11 21:39:41 PDT 
Created attachment 258800 [details]
Patch
Comment 2 Gyuyoung Kim 2015-08-11 21:42:10 PDT 
Created attachment 258801 [details]
Patch
Comment 3 Brent Fulgham 2015-08-13 08:52:50 PDT 
Comment on attachment 258801 [details]
Patch

r=me
Comment 4 Ahmad Saleem 2022-07-24 10:55:12 PDT 
@bfulgham@webkit.org - it is r+ patch, has this landed or it got changed or fixed. There is no test case in the attached patch, which I can use to test it. Appreciate if you can update it accordingly as you needed. Thanks!
Comment 5 Ryosuke Niwa 2022-07-24 13:51:02 PDT 
This is a change for old CSS parser. I'm pretty sure the patch is no longer relevant.