Bug 147920 - [OS X] Remove support for composite fonts
Summary: [OS X] Remove support for composite fonts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
: 147859 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-08-11 19:32 PDT by Myles C. Maxfield
Modified: 2015-08-17 21:55 PDT (History)
1 user (show)

See Also:

Attachments
Patch (242.68 KB, patch)
2015-08-11 19:36 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (242.59 KB, patch)
2015-08-11 19:41 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (243.11 KB, patch)
2015-08-17 17:13 PDT, Myles C. Maxfield 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-08-11 19:32:36 PDT 
[OS X] Remove support for composite fonts
Comment 1 Myles C. Maxfield 2015-08-11 19:36:10 PDT 
Created attachment 258795 [details]
Patch
Comment 2 Myles C. Maxfield 2015-08-11 19:41:02 PDT 
Created attachment 258796 [details]
Patch
Comment 3 Myles C. Maxfield 2015-08-17 17:13:54 PDT 
Created attachment 259213 [details]
Patch
Comment 4 mitz 2015-08-17 18:30:29 PDT 
Comment on attachment 259213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259213&action=review

> Source/WebCore/ChangeLog:13
> +        CTRunGetStringIndices() to map from the code points to the glyphs. This approach is
> +        fundamentally incorrect, as it will combine consecutive code points together in the
> +        string if possible to produce a glyph.

“Fundamentally incorrect” is not a good characterization of the approach. A more accurate statement would be that the implementation of this approach is currently buggy in that it relies on getCFStringAttributes() to return attributes that turn off essential ligatures, but it has become possible for it to be used in cases where getCFStringAttributes() return attributes that do not turn off essential ligatures.

Anyway, I think this preamble is unnecessary.

> Source/WebCore/ChangeLog:15
> +        The only way WebKit will ever trigger this code path is if we are inspecting a

“inspecting”?
Comment 5 Myles C. Maxfield 2015-08-17 19:08:05 PDT 
Committed r188566: <http://trac.webkit.org/changeset/188566>
Comment 6 Myles C. Maxfield 2015-08-17 21:27:38 PDT 
Follow up patch http://trac.webkit.org/changeset/188569
Comment 7 Myles C. Maxfield 2015-08-17 21:55:57 PDT 
*** Bug 147859 has been marked as a duplicate of this bug. ***