Bug 147892 – Don't short circuit seeking

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

HTMLMediaElement does nothing when asked to seek to the time of a pending seek. This can result in a seek to the wrong time when the pending seek was caused by a call to fastSeek and the seek that is ignored is an exact seek.

[Eric Carlson]

<rdar://problem/21367467>

[Eric Carlson]

Created attachment 258755 [details]
Patch to preview, tests will follow.

[WebKit Commit Bot]

Attachment 258755 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 258755 [details]
Patch to preview, tests will follow.

Attachment 258755 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/46021

New failing tests:
media/track/track-cues-seeking.html
media/track/track-cue-rendering-rtl.html
media/track/track-css-cue-lifetime.html
media/media-controller-playbackrate.html
media/track/track-in-band-style.html
media/track/track-cue-rendering-snap-to-lines-not-set.html
media/track/track-cue-nothing-to-render.html
media/track/regions-webvtt/vtt-region-display.html
media/track/track-css-matching.html
media/track/track-css-matching-timestamps.html
media/track/track-cue-overlap-snap-to-lines-not-set.html

[Build Bot]

Created attachment 258756 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 258755 [details]
Patch to preview, tests will follow.

Attachment 258755 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/46042

New failing tests:
media/track/track-cues-seeking.html
media/track/track-cue-rendering-rtl.html
media/track/track-css-cue-lifetime.html
media/media-controller-playbackrate.html
media/track/track-in-band-style.html
media/track/track-cue-rendering-snap-to-lines-not-set.html
media/track/track-cue-nothing-to-render.html
media/track/regions-webvtt/vtt-region-display.html
media/track/track-css-matching.html
media/track/track-css-matching-timestamps.html
media/track/track-cue-overlap-snap-to-lines-not-set.html

[Build Bot]

Created attachment 258758 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Eric Carlson]

Created attachment 258840 [details]
Updated patch

[Jer Noble]

Comment on attachment 258840 [details]
Updated patch

Nit, the patch doesn't apply to ToT.

View in context: https://bugs.webkit.org/attachment.cgi?id=258840&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1315
> -        callOnMainThread([weakThis, finished] {
> +        double currentTime = CMTimeGetSeconds([m_avPlayerItem currentTime]);
> +        callOnMainThread([weakThis, finished, currentTime] {
>              auto _this = weakThis.get();
> +            LOG(Media, "MediaPlayerPrivateAVFoundationObjC::seekToTime(%p) - completion handler called, currentTime = %f", _this, currentTime);
>              if (!_this)

I think this is going to result in a "unused parameter warning/error" on non-logging builds; you may want to add UNUSED_PARAM() inside the block.

[Eric Carlson]

Created attachment 258870 [details]
Patch for landing

[Eric Carlson]

Created attachment 258871 [details]
Patch for landing

[Build Bot]

Comment on attachment 258871 [details]
Patch for landing

Attachment 258871 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/51185

New failing tests:
media/video-played-ranges-1.html
media/video-played-collapse.html
media/video-pause-immediately.html

[Build Bot]

Created attachment 258874 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 258871 [details]
Patch for landing

Attachment 258871 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/51196

New failing tests:
media/video-played-ranges-1.html
media/video-pause-immediately.html

[Build Bot]

Created attachment 258875 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Eric Carlson]

Created attachment 258889 [details]
Updated patch for landing

[Eric Carlson]

Created attachment 258898 [details]
Another updated patch for landing

[Build Bot]

Comment on attachment 258898 [details]
Another updated patch for landing

Attachment 258898 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/53601

New failing tests:
media/video-played-ranges-1.html
media/video-played-collapse.html
media/video-pause-immediately.html

[Build Bot]

Created attachment 258902 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Eric Carlson]

Created attachment 258905 [details]
YAUPFL

[WebKit Commit Bot]

Comment on attachment 258905 [details]
YAUPFL

Clearing flags on attachment: 258905

Committed r188390: <http://trac.webkit.org/changeset/188390>

[Jer Noble]

Created attachment 258941 [details]
Follow up patch

Pre-reviewed by Eric Carlson in person.

[Jer Noble]

Created attachment 258943 [details]
Follow up patch

Pre-reviewed by Eric Carlson in person.

[WebKit Commit Bot]

Comment on attachment 258943 [details]
Follow up patch

Clearing flags on attachment: 258943

Committed r188416: <http://trac.webkit.org/changeset/188416>

[Csaba Osztrogonác]

Already landed, let's close it.