We still use the safe bool idiom (UnspecifiedBoolType) from pre C++11 in WTF. We should replace the safe bool idiom with explicit bool() instead.
Created attachment 258732 [details] Patch
Created attachment 259227 [details] Patch rebased so it should, hopefully, apply.
Attachment 259227 [details] did not pass style-queue: ERROR: Source/WTF/wtf/RetainPtr.h:31: Streams are highly discouraged. [readability/streams] [3] Total errors found: 1 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 259227 [details] Patch EWS still angry
Created attachment 259304 [details] Patch Let's try this again...
Comment on attachment 259304 [details] Patch I shed a single tear over all this !! nonsense. I do not not dislike it.
Comment on attachment 259304 [details] Patch Rejecting attachment 259304 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: a -c /Volumes/Data/EWS/WebKit/Source/WebCore/loader/archive/ArchiveResource.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/ArchiveResource.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/ApplicationCacheGroup.o loader/appcache/ApplicationCacheGroup.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/73245
What's the status of this bug? Did Geoff scare off Keith? I saw the use of UnspecifiedBoolType in the sources and thought I'd get rid of it. But first I checked to see if there was any reason recorded for not not keeping it. That brought me to this bug. Is there any reason to not not not move forward with it?