Bug 147880 – [Win] Popup menus have incorrect placement when device scale factor != 1.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

We need to take the device scaling factor into account when calculating the position and size of the popup menu.

Created attachment 258717 [details]
Patch

[Brent Fulgham]

Comment on attachment 258717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258717&action=review

r=me.

> Source/WebCore/platform/win/PopupMenuWin.cpp:291
> +    if (!::ClientToScreen(hostWindow, &absoluteLocation))

Heh -- nice simplification! :-)

> Source/WebCore/platform/win/PopupMenuWin.cpp:317
> +    Page* page = v->frame().page();

How about: "if (Page* page = v->frame().page()) ..." ?

(In reply to comment #2)
> Comment on attachment 258717 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258717&action=review
> 
> r=me.
> 

Thanks!

> > Source/WebCore/platform/win/PopupMenuWin.cpp:291
> > +    if (!::ClientToScreen(hostWindow, &absoluteLocation))
> 
> Heh -- nice simplification! :-)
> 
> > Source/WebCore/platform/win/PopupMenuWin.cpp:317
> > +    Page* page = v->frame().page();
> 
> How about: "if (Page* page = v->frame().page()) ..." ?

I would have changed this, but now I see it's already in the commit queue :)

[Brent Fulgham]

(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 258717 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=258717&action=review
> > 
> > r=me.
> > 
> 
> Thanks!
> 
> > > Source/WebCore/platform/win/PopupMenuWin.cpp:291
> > > +    if (!::ClientToScreen(hostWindow, &absoluteLocation))
> > 
> > Heh -- nice simplification! :-)
> > 
> > > Source/WebCore/platform/win/PopupMenuWin.cpp:317
> > > +    Page* page = v->frame().page();
> > 
> > How about: "if (Page* page = v->frame().page()) ..." ?
> 
> I would have changed this, but now I see it's already in the commit queue :)

Yes -- that's my fault! Don't worry about the change. I was just writing comments as I read the patch. :-)

(In reply to comment #4)
> 
> Yes -- that's my fault! Don't worry about the change. I was just writing
> comments as I read the patch. :-)

Ok, thanks :)

[WebKit Commit Bot]

Comment on attachment 258717 [details]
Patch

Clearing flags on attachment: 258717

Committed r188259: <http://trac.webkit.org/changeset/188259>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.