Bug 147872 - [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
Summary: [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in did...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on: 147871 148317
Blocks:
  Show dependency tree / graph
 
Reported: 2015-08-11 00:16 PDT by Andy Estes
Modified: 2015-08-23 23:48 PDT (History)
8 users (show)

See Also:

Attachments
Patch (28.85 KB, patch)
2015-08-23 17:40 PDT, Andy Estes 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-08-11 00:16:21 PDT 
When Content Filtering is enabled and a server redirect occurs, the provisional URL does is not updated to the redirect URL when didReceiveServerRedirectForProvisionalLoadForFrame is sent to the load delegate.
Comment 1 Andy Estes 2015-08-11 00:18:05 PDT 
rdar://problem/22044000
Comment 2 Andy Estes 2015-08-23 17:40:11 PDT 
Created attachment 259742 [details]
Patch
Comment 3 mitz 2015-08-23 18:12:22 PDT 
Comment on attachment 259742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259742&action=review

> Tools/TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:32
> +LD_RUNPATH_SEARCH_PATHS = "@loader_path/../../..";

Is this number of ../ right for iOS as well?

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:38
> +static bool isDone = false;

Don’t have to initialize to false.
Comment 4 Andy Estes 2015-08-23 22:36:42 PDT 
(In reply to comment #3)
> Comment on attachment 259742 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259742&action=review
> 
> > Tools/TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:32
> > +LD_RUNPATH_SEARCH_PATHS = "@loader_path/../../..";
> 
> Is this number of ../ right for iOS as well?

Nope, it's not. Good catch.

> 
> > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:38
> > +static bool isDone = false;
> 
> Don’t have to initialize to false.

Ok. Thanks again for the review!
Comment 5 Andy Estes 2015-08-23 23:48:50 PDT 
Committed r188851: <http://trac.webkit.org/changeset/188851>