Bug 147872 – [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Andy Estes]

When Content Filtering is enabled and a server redirect occurs, the provisional URL does is not updated to the redirect URL when didReceiveServerRedirectForProvisionalLoadForFrame is sent to the load delegate.

[Andy Estes]

rdar://problem/22044000

[Andy Estes]

Created attachment 259742 [details]
Patch

Comment on attachment 259742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259742&action=review

> Tools/TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:32
> +LD_RUNPATH_SEARCH_PATHS = "@loader_path/../../..";

Is this number of ../ right for iOS as well?

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:38
> +static bool isDone = false;

Don’t have to initialize to false.

[Andy Estes]

(In reply to comment #3)
> Comment on attachment 259742 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259742&action=review
> 
> > Tools/TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:32
> > +LD_RUNPATH_SEARCH_PATHS = "@loader_path/../../..";
> 
> Is this number of ../ right for iOS as well?

Nope, it's not. Good catch.

> 
> > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:38
> > +static bool isDone = false;
> 
> Don’t have to initialize to false.

Ok. Thanks again for the review!

[Andy Estes]

Committed r188851: <http://trac.webkit.org/changeset/188851>