Bug 147863 - Ref-ify SharedBuffer
Summary: Ref-ify SharedBuffer
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-10 19:21 PDT by Andreas Kling
Modified: 2017-03-14 13:07 PDT (History)
2 users (show)

See Also:

Attachments
Patch for EWS (22.45 KB, patch)
2015-08-10 19:23 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch for EWS 2 (21.39 KB, patch)
2015-08-10 19:37 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-08-10 19:21:36 PDT 
SharedBuffer's create() functions should return Refs.
Also, its internal DataBuffer should be stored in a Ref.
Comment 1 Andreas Kling 2015-08-10 19:23:41 PDT 
Created attachment 258685 [details]
Patch for EWS
Comment 2 WebKit Commit Bot 2015-08-10 19:26:29 PDT 
Attachment 258685 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/SharedBuffer.h:62:  The parameter name "vector" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/SharedBuffer.h:68:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2015-08-10 19:37:26 PDT 
Created attachment 258688 [details]
Patch for EWS 2
Comment 4 Andreas Kling 2017-03-14 13:07:07 PDT 
Someone else made these changes somewhere in the last year.