WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
147863
Ref-ify SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=147863
Summary
Ref-ify SharedBuffer
Andreas Kling
Reported
2015-08-10 19:21:36 PDT
SharedBuffer's create() functions should return Refs. Also, its internal DataBuffer should be stored in a Ref.
Attachments
Patch for EWS
(22.45 KB, patch)
2015-08-10 19:23 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Patch for EWS 2
(21.39 KB, patch)
2015-08-10 19:37 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2015-08-10 19:23:41 PDT
Created
attachment 258685
[details]
Patch for EWS
WebKit Commit Bot
Comment 2
2015-08-10 19:26:29 PDT
Attachment 258685
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/SharedBuffer.h:62: The parameter name "vector" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/SharedBuffer.h:68: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3
2015-08-10 19:37:26 PDT
Created
attachment 258688
[details]
Patch for EWS 2
Andreas Kling
Comment 4
2017-03-14 13:07:07 PDT
Someone else made these changes somewhere in the last year.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug