Bug 147856 - Start beating UnlinkedCodeBlock.h/.cpp with the "One Class per File" stick
Summary: Start beating UnlinkedCodeBlock.h/.cpp with the "One Class per File" stick
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-10 17:15 PDT by Geoffrey Garen
Modified: 2015-08-10 18:26 PDT (History)
1 user (show)

See Also:

Attachments
Patch (179.20 KB, patch)
2015-08-10 17:16 PDT, Geoffrey Garen 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-08-10 17:15:24 PDT 
Start beating UnlinkedCodeBlock.h/.cpp with the "One Class per File" stick
Comment 1 Geoffrey Garen 2015-08-10 17:16:28 PDT 
Created attachment 258676 [details]
Patch
Comment 2 WebKit Commit Bot 2015-08-10 17:18:39 PDT 
Attachment 258676 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2015-08-10 17:27:36 PDT 
Comment on attachment 258676 [details]
Patch

r=me
Comment 4 Geoffrey Garen 2015-08-10 18:26:47 PDT 
Committed r188242: <http://trac.webkit.org/changeset/188242>