WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
147856
Start beating UnlinkedCodeBlock.h/.cpp with the "One Class per File" stick
https://bugs.webkit.org/show_bug.cgi?id=147856
Summary
Start beating UnlinkedCodeBlock.h/.cpp with the "One Class per File" stick
Geoffrey Garen
Reported
2015-08-10 17:15:24 PDT
Start beating UnlinkedCodeBlock.h/.cpp with the "One Class per File" stick
Attachments
Patch
(179.20 KB, patch)
2015-08-10 17:16 PDT
,
Geoffrey Garen
saam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2015-08-10 17:16:28 PDT
Created
attachment 258676
[details]
Patch
WebKit Commit Bot
Comment 2
2015-08-10 17:18:39 PDT
Attachment 258676
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 3
2015-08-10 17:27:36 PDT
Comment on
attachment 258676
[details]
Patch r=me
Geoffrey Garen
Comment 4
2015-08-10 18:26:47 PDT
Committed
r188242
: <
http://trac.webkit.org/changeset/188242
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug