Bug 147850 - Add more strict mode tests
Summary: Add more strict mode tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basile Clement
URL:
Keywords:
Depends on:
Blocks: 146477
  Show dependency tree / graph
 
Reported: 2015-08-10 15:46 PDT by Basile Clement
Modified: 2015-09-03 19:43 PDT (History)
1 user (show)

See Also:

Attachments
Patch (458.85 KB, patch)
2015-08-11 12:41 PDT, Basile Clement 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basile Clement 2015-08-10 15:46:34 PDT 
...
Comment 1 Basile Clement 2015-08-11 12:41:27 PDT 
Created attachment 258737 [details]
Patch
Comment 2 Michael Saboff 2015-08-11 12:59:41 PDT 
Comment on attachment 258737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258737&action=review

r=me

> Source/JavaScriptCore/ChangeLog:17
> +        * tests/stress/v8-crypto-strict.js: Added.

I think it would be better to just list the new test file names and not the individual functions.
Comment 3 Basile Clement 2015-08-11 13:03:53 PDT 
(In reply to comment #2)
> Comment on attachment 258737 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258737&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ChangeLog:17
> > +        * tests/stress/v8-crypto-strict.js: Added.
> 
> I think it would be better to just list the new test file names and not the
> individual functions.

That makes sense, changing that before landing.
Comment 4 Basile Clement 2015-08-11 13:07:19 PDT 
Committed r188281 <http://trac.webkit.org/changeset/188281>
Comment 5 Basile Clement 2015-08-31 18:20:27 PDT 
(In reply to comment #4)
> Committed r188281 <http://trac.webkit.org/changeset/188281>

This was on the jsc-tailcall branch.
Comment 6 Basile Clement 2015-09-03 19:43:45 PDT 
Committed r189335: <http://trac.webkit.org/changeset/189335>