Bug 147842 – HTMLMediaElement needs way to find MediaDeviceInfo keys

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Matthew Daiter]

Needed way for the HTMLMediaElement to find the MediaDeviceInfo keys. Must have this known so that the player can grab the keys and use them for interpreting the unique ids on the system.

[Matthew Daiter]

Created attachment 258651 [details]
Patch

[Matthew Daiter]

Created attachment 258653 [details]
Patch

[Jer Noble]

Comment on attachment 258653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258653&action=review

> Source/WebCore/page/Settings.h:275
> +    void setMediaDeviceInformationKeysStorageDirectory(const String& directory) { m_mediaDeviceInformationKeysStorageDirectory = directory; }
> +    const String& mediaDeviceInformationKeysStorageDirectory() const { return m_mediaDeviceInformationKeysStorageDirectory; }

Are you storing "media device information keys"? Or are you storing "media device identifiers"?  I'd argue it's the latter, which would make this "mediaDeviceIdentifierStorageDirectory()"

[Matthew Daiter]

Created attachment 258657 [details]
Patch

[Matthew Daiter]

Comment on attachment 258653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258653&action=review

>> Source/WebCore/page/Settings.h:275
>> +    const String& mediaDeviceInformationKeysStorageDirectory() const { return m_mediaDeviceInformationKeysStorageDirectory; }
> 
> Are you storing "media device information keys"? Or are you storing "media device identifiers"?  I'd argue it's the latter, which would make this "mediaDeviceIdentifierStorageDirectory()"

Fixed!

[WebKit Commit Bot]

Comment on attachment 258657 [details]
Patch

Clearing flags on attachment: 258657

Committed r188234: <http://trac.webkit.org/changeset/188234>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.