Bug 147838 - Add WKOriginDataManager entry for MediaDeviceInfoKeys
Summary: Add WKOriginDataManager entry for MediaDeviceInfoKeys
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matthew Daiter
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-10 13:05 PDT by Matthew Daiter
Modified: 2016-02-12 14:29 PST (History)
9 users (show)

See Also:


Attachments
Patch (1.29 KB, patch)
2015-08-10 13:10 PDT, Matthew Daiter
sam: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Daiter 2015-08-10 13:05:53 PDT
Need to teach WebKit2 how to manage the origin of which MediaDeviceInformation key was generated from which website (if we store per website, as was a possibility when discussed).
Comment 1 Matthew Daiter 2015-08-10 13:08:08 PDT
Current API only uses IndexedDataBbaseData type, still should add enum type to conform to other key/storage implementations
Comment 2 Matthew Daiter 2015-08-10 13:10:29 PDT
Created attachment 258642 [details]
Patch
Comment 3 Sam Weinig 2015-08-10 13:50:42 PDT
Comment on attachment 258642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258642&action=review

> Source/WebKit2/UIProcess/API/C/WKOriginDataManager.h:48
> +#if ENABLE(MEDIA_STREAM)
> +    kWKMediaDeviceInformationKeyStorageOriginData = 1 << 9,
> +#endif
>  

ENABLE macros can't go in SPI/API headers.
Comment 4 Anders Carlsson 2016-02-12 14:29:04 PST
We got rid of WKOriginDataManager.
Comment 5 Radar WebKit Bug Importer 2016-02-12 14:29:27 PST
<rdar://problem/24636476>