Needed to create a legacy storage directory for placing MediaDeviceIdentifierKeys
Created attachment 258631 [details] Patch
Created attachment 258648 [details] Patch
Created attachment 258660 [details] Patch
Created attachment 265063 [details] Rebased patch
<rdar://problem/23463882>
Comment on attachment 265063 [details] Rebased patch View in context: https://bugs.webkit.org/attachment.cgi?id=265063&action=review > Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp:57 > - > + Please don’t make this whitespace change. > Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h:89 > + const WTF::String& mediaDeviceIdentifierStorageDirectory() const { return m_mediaDeviceIdentifierStorageDirectory; } > + void setMediaDeviceIdentifierStorageDirectory(const WTF::String& mediaDeviceIdentifierStorageDirectory) { m_mediaDeviceIdentifierStorageDirectory = mediaDeviceIdentifierStorageDirectory; } Not sure why this file calls it WTF::String instead of String. > Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp:116 > + // FIXME: Implement Normally it’s a period at the end of each of these. I don’t understand the status of these functions. Do these really need to be implemented? Or should this be oure virtual instead. Seems a little bit mysterious what the plan is for non-Cocoa, non-GTK platforms. I don’t think our platform independence strategy here is very good.
Comment on attachment 265063 [details] Rebased patch View in context: https://bugs.webkit.org/attachment.cgi?id=265063&action=review >> Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp:57 >> + > > Please don’t make this whitespace change. Fixed. >> Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h:89 >> + void setMediaDeviceIdentifierStorageDirectory(const WTF::String& mediaDeviceIdentifierStorageDirectory) { m_mediaDeviceIdentifierStorageDirectory = mediaDeviceIdentifierStorageDirectory; } > > Not sure why this file calls it WTF::String instead of String. A "String" in this file is an "API::String", which can't be automatically converted to WTF::String. All of the existing methods that return a directory path return "const WTF::String&". >> Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp:116 >> + // FIXME: Implement > > Normally it’s a period at the end of each of these. > > I don’t understand the status of these functions. Do these really need to be implemented? Or should this be oure virtual instead. Seems a little bit mysterious what the plan is for non-Cocoa, non-GTK platforms. I don’t think our platform independence strategy here is very good. All of the methods in this class that return Strings (directories) are static (defaultApplicationCacheDirectory, defaultNetworkCacheDirectory, etc). I don't know why it is done this way, but I will talk to Anders.
Created attachment 265075 [details] Updated patch
Created attachment 265083 [details] Updated patch
Comment on attachment 265083 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=265083&action=review r=me > Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp:116 > + // FIXME: Implement notImplemented()?
Comment on attachment 265083 [details] Updated patch This is no longer needed.