Existing disk-cache tests currently cover disk and XHR memory cache validation behaviors. They can be extended to cover regular subresource policy too.
Created attachment 258891 [details] patch
Comment on attachment 258891 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=258891&action=review Nice! > Source/WebCore/loader/FrameLoader.h:288 > + void setStrictRawResourceValidationPolicyDisabledForTesting(bool b) { m_isStrictRawResourceValidationPolicyDisabledForTesting = b; } I'd use a real word instead of "b" here. > Source/WebCore/loader/FrameLoader.h:289 > + bool isStrictRawResourceValidationPolicyDisabledForTesting() { return m_isStrictRawResourceValidationPolicyDisabledForTesting; } strictRawResourceValidationPolicyIsDisabledForTesting would result in better grammar in conditional constructs. > Source/WebCore/loader/cache/CachedResourceLoader.cpp:699 > + // FIXME: We should have same cache policy for all resource types. It is good to add a FIXME here. It would be even more helpful to explain why. > Source/WebCore/loader/cache/CachedResourceLoader.cpp:701 > + bool strictPolicyDisabled = frame()->loader().isStrictRawResourceValidationPolicyDisabledForTesting(); When we use frame() elsewhere in this function, it's passed down to logMemoryCacheResourceRequest, which has a null check. It seems that frame can't be null, yet I wanted to call your attention to the fact that the patch adds what looks like the first unchecked use of frame in this function.
https://trac.webkit.org/r188468
<rdar://problem/11740403>