Bug 147819 - [font-features] Map OpenType feature tags to TrueType feature selectors
Summary: [font-features] Map OpenType feature tags to TrueType feature selectors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-09 19:09 PDT by Myles C. Maxfield
Modified: 2015-08-11 19:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.75 KB, patch)
2015-08-09 19:11 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (148.47 KB, patch)
2015-08-10 20:14 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (148.66 KB, patch)
2015-08-10 21:32 PDT, Myles C. Maxfield 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-08-09 19:09:27 PDT 
[font-features] Map OpenType feature tags to TrueType feature selectors
Comment 1 Myles C. Maxfield 2015-08-09 19:11:26 PDT 
Created attachment 258604 [details]
Patch
Comment 2 Myles C. Maxfield 2015-08-10 20:14:28 PDT 
Created attachment 258692 [details]
Patch
Comment 3 Myles C. Maxfield 2015-08-10 21:32:11 PDT 
Created attachment 258701 [details]
Patch
Comment 4 Dean Jackson 2015-08-11 12:09:12 PDT 
Comment on attachment 258701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258701&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:83
> +        if (feature.value() == 1) {
> +            appendRawTrueTypeFeature(features, kLigaturesType, kCommonLigaturesOnSelector);
> +            appendRawTrueTypeFeature(features, kLigaturesType, kContextualLigaturesOnSelector);
> +        } else if (!feature.value()) {

Seems like you do this often enough that I wonder if FontFeature should have a enabled() accessor that checks == 1. But I can't remember at the moment what FontFeature looks like.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:115
> +        appendRawTrueTypeFeature(features, kLetterCaseType, 14); // we hates this feature

Did you mean to leave this in? If so, please explain.
Comment 5 Myles C. Maxfield 2015-08-11 19:00:19 PDT 
Committed r188319: <http://trac.webkit.org/changeset/188319>