WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
147819
[font-features] Map OpenType feature tags to TrueType feature selectors
https://bugs.webkit.org/show_bug.cgi?id=147819
Summary
[font-features] Map OpenType feature tags to TrueType feature selectors
Myles C. Maxfield
Reported
2015-08-09 19:09:27 PDT
[font-features] Map OpenType feature tags to TrueType feature selectors
Attachments
Patch
(11.75 KB, patch)
2015-08-09 19:11 PDT
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
Patch
(148.47 KB, patch)
2015-08-10 20:14 PDT
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
Patch
(148.66 KB, patch)
2015-08-10 21:32 PDT
,
Myles C. Maxfield
dino
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2015-08-09 19:11:26 PDT
Created
attachment 258604
[details]
Patch
Myles C. Maxfield
Comment 2
2015-08-10 20:14:28 PDT
Created
attachment 258692
[details]
Patch
Myles C. Maxfield
Comment 3
2015-08-10 21:32:11 PDT
Created
attachment 258701
[details]
Patch
Dean Jackson
Comment 4
2015-08-11 12:09:12 PDT
Comment on
attachment 258701
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=258701&action=review
> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:83 > + if (feature.value() == 1) { > + appendRawTrueTypeFeature(features, kLigaturesType, kCommonLigaturesOnSelector); > + appendRawTrueTypeFeature(features, kLigaturesType, kContextualLigaturesOnSelector); > + } else if (!feature.value()) {
Seems like you do this often enough that I wonder if FontFeature should have a enabled() accessor that checks == 1. But I can't remember at the moment what FontFeature looks like.
> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:115 > + appendRawTrueTypeFeature(features, kLetterCaseType, 14); // we hates this feature
Did you mean to leave this in? If so, please explain.
Myles C. Maxfield
Comment 5
2015-08-11 19:00:19 PDT
Committed
r188319
: <
http://trac.webkit.org/changeset/188319
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug